[Qemu-devel] [PATCH 0/3] Risu PPC improvements

[Qemu-devel] [PATCH 0/3] Risu PPC improvements

[Nikunj A Dadhania]

The series contains some fixes/cleanup for ppc64le

Nikunj A Dadhania (3):
  risu_ppc64le: set r23 as the comment says
  risu_ppc64le: zero the xer register
  risu_ppc64le: remove aarch64 related comments

 risugen_ppc64.pm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

-- 
2.7.4

[Qemu-devel] [PATCH 1/3] risu_ppc64le: set r23 as the comment says

[Nikunj A Dadhania]

Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
---
 risugen_ppc64.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/risugen_ppc64.pm b/risugen_ppc64.pm
index 8e323a2..0532e3a 100644
--- a/risugen_ppc64.pm
+++ b/risugen_ppc64.pm
@@ -167,9 +167,9 @@ sub clear_vr_registers()
     # addi r22, r1, 32
     insn32(0x3ac10020);
     # li r23, 0
-    write_mov_ri(23, 1);
+    write_mov_ri(23, 0);
     # std r23, 0(r22)
-    insn32(0xfaf60000); 
+    insn32(0xfaf60000);
 
     for (my $i = 0; $i < 32; $i++) {
         # vxor i, i, i
-- 
2.7.4

[Qemu-devel] [PATCH 2/3] risu_ppc64le: zero the xer register

[Nikunj A Dadhania]

Observed failures running with P9 mambo model, and figured out that the
xer wasn't initialized.

Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
---
 risugen_ppc64.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/risugen_ppc64.pm b/risugen_ppc64.pm
index 0532e3a..03f9317 100644
--- a/risugen_ppc64.pm
+++ b/risugen_ppc64.pm
@@ -168,6 +168,9 @@ sub clear_vr_registers()
     insn32(0x3ac10020);
     # li r23, 0
     write_mov_ri(23, 0);
+    # zero the xer register
+    # mtxer   r23
+    insn32(0x7ee103a6);
     # std r23, 0(r22)
     insn32(0xfaf60000);
 
-- 
2.7.4

[Qemu-devel] [PATCH 3/3] risu_ppc64le: remove aarch64 related comments

[Nikunj A Dadhania]

Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
---
 risugen_ppc64.pm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/risugen_ppc64.pm b/risugen_ppc64.pm
index 03f9317..f208a54 100644
--- a/risugen_ppc64.pm
+++ b/risugen_ppc64.pm
@@ -84,8 +84,6 @@ sub write_sxt32($$)
 
 sub write_mov_ri($$)
 {
-    # We always use a MOVW/MOVT pair, for simplicity.
-    # on aarch64, we use a MOVZ/MOVK pair.
     my ($rd, $imm) = @_;
 
     if (($imm >> 16) & 0xffff) {
-- 
2.7.4

Re: [Qemu-devel] [PATCH 0/3] Risu PPC improvements

[Peter Maydell]

On 9 February 2017 at 05:58, Nikunj A Dadhania
<nikunj@linux.vnet.ibm.com> wrote:
> The series contains some fixes/cleanup for ppc64le
>
> Nikunj A Dadhania (3):
>   risu_ppc64le: set r23 as the comment says
>   risu_ppc64le: zero the xer register
>   risu_ppc64le: remove aarch64 related comments
>
>  risugen_ppc64.pm | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Applied to risu master, thanks.

-- PMM