From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au,
rth@twiddle.net, nikunj@linux.vnet.ibm.com,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: [Qemu-devel] [PATCH 7/7] target-s390: Use float128_to_uint[64/32] where required
Date: Fri, 10 Feb 2017 12:53:11 +0530 [thread overview]
Message-ID: <1486711391-12247-8-git-send-email-bharata@linux.vnet.ibm.com> (raw)
In-Reply-To: <1486711391-12247-1-git-send-email-bharata@linux.vnet.ibm.com>
Use float126_to_uint[64/32] instead of using int versions of the same.
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
CC: Christian Borntraeger <borntraeger@de.ibm.com>
CC: Cornelia Huck <cornelia.huck@de.ibm.com>
---
target/s390x/fpu_helper.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/target/s390x/fpu_helper.c b/target/s390x/fpu_helper.c
index e604e9f..9aa94d9 100644
--- a/target/s390x/fpu_helper.c
+++ b/target/s390x/fpu_helper.c
@@ -515,8 +515,7 @@ uint64_t HELPER(clgxb)(CPUS390XState *env, uint64_t h, uint64_t l, uint32_t m3)
{
int hold = swap_round_mode(env, m3);
float128 v2 = make_float128(h, l);
- /* ??? Not 100% correct. */
- uint64_t ret = float128_to_int64(v2, &env->fpu_status);
+ uint64_t ret = float128_to_uint64(v2, &env->fpu_status);
set_float_rounding_mode(hold, &env->fpu_status);
handle_exceptions(env, GETPC());
return ret;
@@ -547,8 +546,7 @@ uint64_t HELPER(clfxb)(CPUS390XState *env, uint64_t h, uint64_t l, uint32_t m3)
{
int hold = swap_round_mode(env, m3);
float128 v2 = make_float128(h, l);
- /* Not 100% correct. */
- uint32_t ret = float128_to_int64(v2, &env->fpu_status);
+ uint32_t ret = float128_to_uint32(v2, &env->fpu_status);
set_float_rounding_mode(hold, &env->fpu_status);
handle_exceptions(env, GETPC());
return ret;
--
2.7.4
next prev parent reply other threads:[~2017-02-10 7:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 7:23 [Qemu-devel] [PATCH 0/7] POWER9 TCG and softfloat enablements - part16 + s390 float fixes Bharata B Rao
2017-02-10 7:23 ` [Qemu-devel] [PATCH 1/7] softfloat: Add round-to-odd rounding mode Bharata B Rao
2017-02-10 7:23 ` [Qemu-devel] [PATCH 2/7] softfloat: Add float128_to_uint64_round_to_zero() Bharata B Rao
2017-02-10 7:23 ` [Qemu-devel] [PATCH 3/7] softfloat: Add float128_to_uint32_round_to_zero() Bharata B Rao
2017-02-10 7:23 ` [Qemu-devel] [PATCH 4/7] target-ppc: Implement round to odd variants of quad FP instructions Bharata B Rao
2017-02-10 7:23 ` [Qemu-devel] [PATCH 5/7] target-ppc: Add xscvqpudz and xscvqpuwz instructions Bharata B Rao
2017-02-10 7:23 ` [Qemu-devel] [PATCH 6/7] softfloat: Add float128_to_uint32() Bharata B Rao
2017-02-10 7:23 ` Bharata B Rao [this message]
2017-02-13 1:40 ` [Qemu-devel] [PATCH 0/7] POWER9 TCG and softfloat enablements - part16 + s390 float fixes David Gibson
2017-02-13 1:43 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486711391-12247-8-git-send-email-bharata@linux.vnet.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).