From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0tn6-0005Bo-S5 for qemu-devel@nongnu.org; Thu, 12 May 2016 12:48:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0tn1-0005Nx-LN for qemu-devel@nongnu.org; Thu, 12 May 2016 12:48:47 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:46653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0tn1-0005NW-BS for qemu-devel@nongnu.org; Thu, 12 May 2016 12:48:43 -0400 Date: Thu, 12 May 2016 12:48:41 -0400 (EDT) From: Paolo Bonzini Message-ID: <1487093908.13650793.1463071721586.JavaMail.zimbra@redhat.com> In-Reply-To: <1463062204-20330-1-git-send-email-ehabkost@redhat.com> References: <1463062204-20330-1-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] Use &error_fatal in some initialization code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Markus Armbruster > This changes some initialization code in vl.c, qemu-img, qemu-io, > and qemu-nbd to use &error_fatal instead of manual error > checking/reporting. > > The series is based on my machine branch, available at: > git://github.com/ehabkost/qemu.git machine Patches 1-2-6 are obvious. I'm not sure about 3-4-5, these are internal functions where the error is somewhere below "should never happen" (&error_abort)---it actually should never happen, but exiting due to SIGABRT sounds wrong. It's not the kind of function that I'd expect to have an Error** argument... Paolo > Eduardo Habkost (6): > vl: Use &error_fatal when parsing VNC options > vl: Use &error_fatal when parsing monitor options > main-loop: Use Error** to report qemu_signal_init() errors > main-loop: Use &error_fatal when calling qemu_init_main_loop() > main-loop: Make qemu_init_main_loop() and qemu_signal_init() void > Use &error_fatal when initializing crypto on qemu-{img,io,nbd} > > include/qemu/main-loop.h | 2 +- > main-loop.c | 24 ++++++++++-------------- > qemu-img.c | 11 ++--------- > qemu-io.c | 11 ++--------- > qemu-nbd.c | 10 ++-------- > vl.c | 28 ++++------------------------ > 6 files changed, 21 insertions(+), 65 deletions(-) > > -- > 2.5.5 > >