qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Pavel Dovgalyuk <dovgaluk@ispras.ru>
Cc: 'Paolo Bonzini' <pbonzini@redhat.com>,
	'Pavel Dovgalyuk' <pavel.dovgaluk@ispras.ru>,
	qemu-devel@nongnu.org, zyy@google.com,
	marcandre.lureau@gmail.com
Subject: Re: [Qemu-devel] [PATCH v3] audio: make audio poll timer deterministic
Date: Thu, 16 Feb 2017 16:17:56 +0100	[thread overview]
Message-ID: <1487258276.32455.4.camel@redhat.com> (raw)
In-Reply-To: <002f01d28867$9e79ff10$db6dfd30$@ru>

On Do, 2017-02-16 at 18:16 +0300, Pavel Dovgalyuk wrote:
> > From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> > On Di, 2017-02-14 at 12:59 +0100, Paolo Bonzini wrote:
> > > On 14/02/2017 08:15, Pavel Dovgalyuk wrote:
> > > > This patch changes resetting strategy of the audio polling timer.
> > > > It does not change expiration time if the timer is already set.
> > > > This patch is needed to make this timer deterministic and to use execution
> > > > record/replay for audio devices.
> > > >
> > > > audio_reset_timer is used in the function audio_vm_change_state_handler.
> > > > Therefore every time VM is stopped or restarted the timer will be reset
> > > > to new timeout. Virtual clock does not proceed while VM is stopped.
> > > > Therefore there is no need in resetting the timeout when VM restarts.
> > > >
> > > > v2: updated commit message
> > > > v3: now using timer_mod_anticipate function (as suggested by Yurii Zubrytskyi)
> > >
> > > Gerd, feel free to pick either v2 or v3.
> > 
> > Picked up v3 now.
> 
> Thanks!
> 
> And what about patch for audio record/replay?
> http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg00345.html

Picked that one too (busy preparing a audio pull req atm).

cheers,
  Gerd

      reply	other threads:[~2017-02-16 15:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14  7:15 [Qemu-devel] [PATCH v3] audio: make audio poll timer deterministic Pavel Dovgalyuk
2017-02-14 11:59 ` Paolo Bonzini
2017-02-16 15:12   ` Gerd Hoffmann
2017-02-16 15:16     ` Pavel Dovgalyuk
2017-02-16 15:17       ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487258276.32455.4.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=dovgaluk@ispras.ru \
    --cc=marcandre.lureau@gmail.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zyy@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).