From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ceNoo-0007eL-Nv for qemu-devel@nongnu.org; Thu, 16 Feb 2017 10:18:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ceNol-00020x-L4 for qemu-devel@nongnu.org; Thu, 16 Feb 2017 10:18:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50040) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ceNol-00020e-F8 for qemu-devel@nongnu.org; Thu, 16 Feb 2017 10:17:59 -0500 Message-ID: <1487258276.32455.4.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 16 Feb 2017 16:17:56 +0100 In-Reply-To: <002f01d28867$9e79ff10$db6dfd30$@ru> References: <20170214071510.6112.76764.stgit@PASHA-ISP> <1487257950.32455.0.camel@redhat.com> <002f01d28867$9e79ff10$db6dfd30$@ru> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3] audio: make audio poll timer deterministic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk Cc: 'Paolo Bonzini' , 'Pavel Dovgalyuk' , qemu-devel@nongnu.org, zyy@google.com, marcandre.lureau@gmail.com On Do, 2017-02-16 at 18:16 +0300, Pavel Dovgalyuk wrote: > > From: Gerd Hoffmann [mailto:kraxel@redhat.com] > > On Di, 2017-02-14 at 12:59 +0100, Paolo Bonzini wrote: > > > On 14/02/2017 08:15, Pavel Dovgalyuk wrote: > > > > This patch changes resetting strategy of the audio polling timer. > > > > It does not change expiration time if the timer is already set. > > > > This patch is needed to make this timer deterministic and to use ex= ecution > > > > record/replay for audio devices. > > > > > > > > audio_reset_timer is used in the function audio_vm_change_state_han= dler. > > > > Therefore every time VM is stopped or restarted the timer will be r= eset > > > > to new timeout. Virtual clock does not proceed while VM is stopped. > > > > Therefore there is no need in resetting the timeout when VM restart= s. > > > > > > > > v2: updated commit message > > > > v3: now using timer_mod_anticipate function (as suggested by Yurii = Zubrytskyi) > > > > > > Gerd, feel free to pick either v2 or v3. > >=20 > > Picked up v3 now. >=20 > Thanks! >=20 > And what about patch for audio record/replay? > http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg00345.html Picked that one too (busy preparing a audio pull req atm). cheers, Gerd