From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvpVv-0004FD-3Z for qemu-devel@nongnu.org; Thu, 17 Jan 2013 08:28:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvpVt-000150-EA for qemu-devel@nongnu.org; Thu, 17 Jan 2013 08:28:15 -0500 Received: from mx4-phx2.redhat.com ([209.132.183.25]:43309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvpVt-000144-07 for qemu-devel@nongnu.org; Thu, 17 Jan 2013 08:28:13 -0500 Date: Thu, 17 Jan 2013 08:28:11 -0500 (EST) From: Alon Levy Message-ID: <1487580585.10884389.1358429291926.JavaMail.root@redhat.com> In-Reply-To: <50F7F662.4000907@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org ----- Original Message ----- > On 01/16/13 18:59, Alon Levy wrote: > > Regarding orientation setting in windows 7 64 guest: > > Desktop, right click->Screen resolution > > - You can choose Orientation: Landscape, Portrait, Landscape > > (flipped), Portrait (flipped) > > - You can choose Resolution > > - You can click "Advanced Settings", then "List All Modes" at the > > bottom, you get all the modes (i.e. four of each resolution, one > > for each orientation) > > Ah, ok. The driver seems to handle portrait and swap x+y when > creating > a displaysurface. At least I get a 600x800 display upright. > > I can't see a difference between Landscape + Landscape (flipped). > Likewise Portrait + Portrait (flipped). Is there any? > > > There are two changes after applying the "change rom size to 8192" > > patch: > > - there is no longer an Orientation option > > - the modes listed under "List All Modes" reduce as expected > > Ok, so we loose the Portrait mode. > > > Changes to the second patch: > > - no orientations except the normal > > Keeping orientation 0+1 (and dropping the flipped 2+3 versions) > should > make the mode list small enougth that it fits while maintaining > support > for the portrait mode. I'll test if this changes anything for a windows guest & linux guest. > > I think it would also be good to fix the driver to ignore everything > with or ... what was the end of that sentence? > > How about that? > > > - hard code 8192 bytes rom size > > - assert if the required size is larger > > Good. > > cheers, > Gerd > > >