From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 12/24] test-cutils: Cover qemu_strtosz() with trailing crap
Date: Tue, 21 Feb 2017 21:13:56 +0100 [thread overview]
Message-ID: <1487708048-2131-13-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1487708048-2131-1-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
tests/test-cutils.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/tests/test-cutils.c b/tests/test-cutils.c
index dc8cd8d..1773f15 100644
--- a/tests/test-cutils.c
+++ b/tests/test-cutils.c
@@ -1463,6 +1463,23 @@ static void test_qemu_strtosz_invalid(void)
g_assert(endptr == str);
}
+static void test_qemu_strtosz_trailing(void)
+{
+ const char *str;
+ char *endptr = NULL;
+ int64_t res;
+
+ str = "123xxx";
+ res = qemu_strtosz(str, &endptr);
+ g_assert_cmpint(res, ==, 123 * M_BYTE);
+ g_assert(endptr == str + 3);
+
+ str = "1kiB";
+ res = qemu_strtosz(str, &endptr);
+ g_assert_cmpint(res, ==, 1024);
+ g_assert(endptr == str + 2);
+}
+
static void test_qemu_strtosz_erange(void)
{
const char *str = "10E";
@@ -1676,6 +1693,8 @@ int main(int argc, char **argv)
test_qemu_strtosz_float);
g_test_add_func("/cutils/strtosz/invalid",
test_qemu_strtosz_invalid);
+ g_test_add_func("/cutils/strtosz/trailing",
+ test_qemu_strtosz_trailing);
g_test_add_func("/cutils/strtosz/erange",
test_qemu_strtosz_erange);
g_test_add_func("/cutils/strtosz/suffix-unit",
--
2.7.4
next prev parent reply other threads:[~2017-02-21 20:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 20:13 [Qemu-devel] [PATCH v2 00/24] QemuOpts util/cutils: Fix and clean up number conversions Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 01/24] test-qemu-opts: Cover qemu_opts_parse() Markus Armbruster
2017-02-23 10:41 ` Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 02/24] option: Assert value string isn't null Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 03/24] test-cutils: Add missing qemu_strtol()... endptr checks Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 04/24] test-cutils: Clean up qemu_strtoul() result checks Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 05/24] util/cutils: Rewrite documentation of qemu_strtol() & friends Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 06/24] util/cutils: Rename qemu_strtoll(), qemu_strtoull() Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 07/24] util/cutils: Clean up variable names around qemu_strtol() Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 08/24] util/cutils: Clean up control flow around qemu_strtol() a bit Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 09/24] option: Fix to reject invalid and overflowing numbers Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 10/24] test-cutils: Add missing qemu_strtosz()... endptr checks Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 11/24] test-cutils: Cover qemu_strtosz() invalid input Markus Armbruster
2017-02-21 20:13 ` Markus Armbruster [this message]
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 13/24] test-cutils: Cover qemu_strtosz() around range limits Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 14/24] util/cutils: New qemu_strtosz_metric() Markus Armbruster
2017-02-21 20:13 ` [Qemu-devel] [PATCH v2 15/24] util/cutils: Rename qemu_strtosz() to qemu_strtosz_MiB() Markus Armbruster
2017-02-21 20:14 ` [Qemu-devel] [PATCH v2 16/24] util/cutils: New qemu_strtosz() Markus Armbruster
2017-02-21 20:14 ` [Qemu-devel] [PATCH v2 17/24] util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_* macros Markus Armbruster
2017-02-21 20:14 ` [Qemu-devel] [PATCH v2 18/24] test-cutils: Use qemu_strtosz() more often Markus Armbruster
2017-02-21 20:14 ` [Qemu-devel] [PATCH v2 19/24] test-cutils: Drop suffix from test_qemu_strtosz_simple() Markus Armbruster
2017-02-21 20:14 ` [Qemu-devel] [PATCH v2 20/24] qemu-img: Wrap cvtnum() around qemu_strtosz() Markus Armbruster
2017-02-21 20:14 ` [Qemu-devel] [PATCH v2 21/24] util/cutils: Let qemu_strtosz*() optionally reject trailing crap Markus Armbruster
2017-02-21 20:14 ` [Qemu-devel] [PATCH v2 22/24] util/cutils: Return qemu_strtosz*() error and value separately Markus Armbruster
2017-02-21 20:14 ` [Qemu-devel] [PATCH v2 23/24] util/cutils: Change qemu_strtosz*() from int64_t to uint64_t Markus Armbruster
2017-02-21 20:14 ` [Qemu-devel] [PATCH v2 24/24] option: Fix checking of sizes for overflow and trailing crap Markus Armbruster
2017-02-21 20:47 ` [Qemu-devel] [PATCH v2 00/24] QemuOpts util/cutils: Fix and clean up number conversions no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487708048-2131-13-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).