* [Qemu-devel] [PATCH] usb: ohci: fix error return code in servicing td
@ 2017-02-22 10:56 Li Qiang
2017-02-22 14:22 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Li Qiang @ 2017-02-22 10:56 UTC (permalink / raw)
To: kraxel, qemu-devel; +Cc: ppandit, Li Qiang
It should return 1 if an error occurs when reading td.
This will avoid an infinite loop issue in ohci_service_ed_list.
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
---
hw/usb/hcd-ohci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 21c93e0..fe8406a 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -1001,7 +1001,7 @@ static int ohci_service_td(OHCIState *ohci, struct ohci_ed *ed)
if (ohci_read_td(ohci, addr, &td)) {
trace_usb_ohci_td_read_error(addr);
ohci_die(ohci);
- return 0;
+ return 1;
}
dir = OHCI_BM(ed->flags, ED_D);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] usb: ohci: fix error return code in servicing td
2017-02-22 10:56 [Qemu-devel] [PATCH] usb: ohci: fix error return code in servicing td Li Qiang
@ 2017-02-22 14:22 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-02-22 14:22 UTC (permalink / raw)
To: Li Qiang, qemu-devel; +Cc: kraxel, Li Qiang, ppandit
On 02/22/2017 07:56 AM, Li Qiang wrote:
> It should return 1 if an error occurs when reading td.
> This will avoid an infinite loop issue in ohci_service_ed_list.
>
> Signed-off-by: Li Qiang <liqiang6-s@360.cn>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/usb/hcd-ohci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
> index 21c93e0..fe8406a 100644
> --- a/hw/usb/hcd-ohci.c
> +++ b/hw/usb/hcd-ohci.c
> @@ -1001,7 +1001,7 @@ static int ohci_service_td(OHCIState *ohci, struct ohci_ed *ed)
> if (ohci_read_td(ohci, addr, &td)) {
> trace_usb_ohci_td_read_error(addr);
> ohci_die(ohci);
> - return 0;
> + return 1;
> }
>
> dir = OHCI_BM(ed->flags, ED_D);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-22 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-22 10:56 [Qemu-devel] [PATCH] usb: ohci: fix error return code in servicing td Li Qiang
2017-02-22 14:22 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).