From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 00/24] option cutils: Fix and clean up number conversions
Date: Thu, 23 Feb 2017 20:53:38 +0100 [thread overview]
Message-ID: <1487879642-16139-1-git-send-email-armbru@redhat.com> (raw)
QemuOpts has its own code to convert strings to numbers, and being
QemuOpts, it gets it wrong. util/cutils is less wrong. Fix it up
some, and reuse it for QemuOpts.
The following changes since commit 10f25e4844cb9b3f02fb032f88051dd5b65b4206:
Merge remote-tracking branch 'remotes/yongbok/tags/mips-20170222' into staging (2017-02-23 09:59:40 +0000)
are available in the git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-util-2017-02-23
for you to fetch changes up to 75cdcd1553e74b5edc58aed23e3b2da8dabb1876:
option: Fix checking of sizes for overflow and trailing crap (2017-02-23 20:35:36 +0100)
----------------------------------------------------------------
option cutils: Fix and clean up number conversions
----------------------------------------------------------------
Markus Armbruster (24):
test-qemu-opts: Cover qemu_opts_parse()
option: Assert value string isn't null
test-cutils: Add missing qemu_strtol()... endptr checks
test-cutils: Clean up qemu_strtoul() result checks
util/cutils: Rewrite documentation of qemu_strtol() & friends
util/cutils: Rename qemu_strtoll(), qemu_strtoull()
util/cutils: Clean up variable names around qemu_strtol()
util/cutils: Clean up control flow around qemu_strtol() a bit
option: Fix to reject invalid and overflowing numbers
test-cutils: Add missing qemu_strtosz()... endptr checks
test-cutils: Cover qemu_strtosz() invalid input
test-cutils: Cover qemu_strtosz() with trailing crap
test-cutils: Cover qemu_strtosz() around range limits
util/cutils: New qemu_strtosz_metric()
util/cutils: Rename qemu_strtosz() to qemu_strtosz_MiB()
util/cutils: New qemu_strtosz()
util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_* macros
test-cutils: Use qemu_strtosz() more often
test-cutils: Drop suffix from test_qemu_strtosz_simple()
qemu-img: Wrap cvtnum() around qemu_strtosz()
util/cutils: Let qemu_strtosz*() optionally reject trailing crap
util/cutils: Return qemu_strtosz*() error and value separately
util/cutils: Change qemu_strtosz*() from int64_t to uint64_t
option: Fix checking of sizes for overflow and trailing crap
hmp.c | 11 +-
hw/misc/ivshmem.c | 9 +-
include/qemu/cutils.h | 29 +--
monitor.c | 7 +-
qapi/opts-visitor.c | 11 +-
qemu-img.c | 62 ++---
qemu-io-cmds.c | 16 +-
qobject/qdict.c | 2 +-
qtest.c | 34 +--
target/i386/cpu.c | 9 +-
tests/test-cutils.c | 642 ++++++++++++++++++++++++++++++++-----------------
tests/test-qemu-opts.c | 324 ++++++++++++++++++++++++-
util/cutils.c | 239 +++++++++---------
util/log.c | 4 +-
util/qemu-option.c | 87 +++----
15 files changed, 994 insertions(+), 492 deletions(-)
--
2.7.4
next reply other threads:[~2017-02-23 19:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 19:53 Markus Armbruster [this message]
2017-02-23 19:53 ` [Qemu-devel] [PULL 01/24] test-qemu-opts: Cover qemu_opts_parse() Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 02/24] option: Assert value string isn't null Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 03/24] test-cutils: Add missing qemu_strtol()... endptr checks Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 04/24] test-cutils: Clean up qemu_strtoul() result checks Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 05/24] util/cutils: Rewrite documentation of qemu_strtol() & friends Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 06/24] util/cutils: Rename qemu_strtoll(), qemu_strtoull() Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 07/24] util/cutils: Clean up variable names around qemu_strtol() Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 08/24] util/cutils: Clean up control flow around qemu_strtol() a bit Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 09/24] option: Fix to reject invalid and overflowing numbers Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 10/24] test-cutils: Add missing qemu_strtosz()... endptr checks Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 11/24] test-cutils: Cover qemu_strtosz() invalid input Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 12/24] test-cutils: Cover qemu_strtosz() with trailing crap Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 13/24] test-cutils: Cover qemu_strtosz() around range limits Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 14/24] util/cutils: New qemu_strtosz_metric() Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 15/24] util/cutils: Rename qemu_strtosz() to qemu_strtosz_MiB() Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 16/24] util/cutils: New qemu_strtosz() Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 17/24] util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_* macros Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 18/24] test-cutils: Use qemu_strtosz() more often Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 19/24] test-cutils: Drop suffix from test_qemu_strtosz_simple() Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 20/24] qemu-img: Wrap cvtnum() around qemu_strtosz() Markus Armbruster
2017-02-23 19:53 ` [Qemu-devel] [PULL 21/24] util/cutils: Let qemu_strtosz*() optionally reject trailing crap Markus Armbruster
2017-02-23 19:54 ` [Qemu-devel] [PULL 22/24] util/cutils: Return qemu_strtosz*() error and value separately Markus Armbruster
2017-02-23 19:54 ` [Qemu-devel] [PULL 23/24] util/cutils: Change qemu_strtosz*() from int64_t to uint64_t Markus Armbruster
2017-02-23 19:54 ` [Qemu-devel] [PULL 24/24] option: Fix checking of sizes for overflow and trailing crap Markus Armbruster
2017-02-23 20:37 ` [Qemu-devel] [PULL 00/24] option cutils: Fix and clean up number conversions no-reply
2017-02-25 16:37 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487879642-16139-1-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).