From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, pkrempa@redhat.com,
eblake@redhat.com,
"mdroth@linux.vnet.ibm.commdroth"@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 00/24] block: Command line option -blockdev
Date: Mon, 27 Feb 2017 12:20:26 +0100 [thread overview]
Message-ID: <1488194450-28056-1-git-send-email-armbru@redhat.com> (raw)
Actually, the command line option is the least part of this series.
Its bulk is about building infrastructure and getting errors out of
the JSON parser[*]. The latter part could be spun out in its own
series, if that helps. We'll see.
The design of the command line interface was discussed here:
Subject: Non-flat command line option argument syntax
Message-ID: <87bmukmlau.fsf@dusky.pond.sub.org>
https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg00555.html
This series is based on "[PATCH v2 00/26] qapi: QMP dispatch and input
visitor work". Available as branch blockdev-cmdline in my public repo
<http://repo.or.cz/w/qemu/armbru.git>, except that one still has a
patch to add implied value sugar, followed by its revert.
It supersedes "[PATCH RFC v3 0/5] block: Crude initial implementation
of -blockdev".
[*] Who'd have thunk anyone actually wants to know what's wrong with
his JSON!
Daniel P. Berrange (1):
qapi: qobject input visitor variant for use with keyval_parse()
Markus Armbruster (23):
test-qemu-opts: Cover qemu_opts_parse() of "no"
tests: Fix gcov-files-test-qemu-opts-y, gcov-files-test-logging-y
keyval: New keyval_parse()
test-keyval: Cover use with qobject input visitor
qapi: Factor out common part of qobject input visitor creation
qapi: Factor out common qobject_input_get_keyval()
qobject: Propagate parse errors through qobject_from_jsonv()
libqtest: Fix qmp() & friends to abort on JSON parse errors
qjson: Abort earlier on qobject_from_jsonf() misuse
test-qobject-input-visitor: Abort earlier on bad test input
qobject: Propagate parse errors through qobject_from_json()
block: More detailed syntax error reporting for JSON filenames
check-qjson: Test errors from qobject_from_json()
test-visitor-serialization: Pass &error_abort to qobject_from_json()
monitor: Assert qmp_schema_json[] is sane
qapi: New qobject_input_visitor_new_str() for convenience
block: Initial implementation of -blockdev
qapi: Improve how keyval input visitor reports unexpected dicts
docs/qapi-code-gen.txt: Clarify naming rules
test-qapi-util: New, covering qapi/qapi-util.c
qapi: New parse_qapi_name()
keyval: Restrict key components to valid QAPI names
keyval: Support lists
block.c | 9 +-
docs/qapi-code-gen.txt | 61 ++--
include/qapi/qmp/qjson.h | 8 +-
include/qapi/qobject-input-visitor.h | 21 ++
include/qapi/util.h | 2 +
include/qemu/option.h | 3 +
monitor.c | 2 +-
qapi/qapi-util.c | 47 +++
qapi/qobject-input-visitor.c | 210 +++++++++++-
qemu-options.hx | 7 +
qobject/qjson.c | 14 +-
tests/.gitignore | 2 +
tests/Makefile.include | 10 +-
tests/check-qjson.c | 88 +++--
tests/libqtest.c | 3 +-
tests/test-keyval.c | 619 +++++++++++++++++++++++++++++++++++
tests/test-qapi-util.c | 85 +++++
tests/test-qemu-opts.c | 5 +
tests/test-qobject-input-visitor.c | 190 ++++++++++-
tests/test-visitor-serialization.c | 2 +-
util/Makefile.objs | 1 +
util/keyval.c | 385 ++++++++++++++++++++++
vl.c | 39 +++
23 files changed, 1730 insertions(+), 83 deletions(-)
create mode 100644 tests/test-keyval.c
create mode 100644 tests/test-qapi-util.c
create mode 100644 util/keyval.c
--
2.7.4
next reply other threads:[~2017-02-27 11:21 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 11:20 Markus Armbruster [this message]
2017-02-27 11:20 ` [Qemu-devel] [PATCH 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no" Markus Armbruster
2017-02-28 15:34 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 02/24] tests: Fix gcov-files-test-qemu-opts-y, gcov-files-test-logging-y Markus Armbruster
2017-02-28 15:34 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 03/24] keyval: New keyval_parse() Markus Armbruster
2017-02-28 15:48 ` Kevin Wolf
2017-02-28 16:36 ` Markus Armbruster
2017-02-28 16:57 ` Eric Blake
2017-02-28 18:03 ` Markus Armbruster
2017-02-28 18:51 ` Eric Blake
2017-02-28 19:15 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 04/24] qapi: qobject input visitor variant for use with keyval_parse() Markus Armbruster
2017-02-28 16:03 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 05/24] test-keyval: Cover use with qobject input visitor Markus Armbruster
2017-02-28 16:21 ` Kevin Wolf
2017-02-28 18:04 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 06/24] qapi: Factor out common part of qobject input visitor creation Markus Armbruster
2017-02-28 16:24 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 07/24] qapi: Factor out common qobject_input_get_keyval() Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 08/24] qobject: Propagate parse errors through qobject_from_jsonv() Markus Armbruster
2017-02-28 16:32 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 09/24] libqtest: Fix qmp() & friends to abort on JSON parse errors Markus Armbruster
2017-02-28 16:51 ` Kevin Wolf
2017-02-28 18:05 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse Markus Armbruster
2017-02-28 16:51 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 11/24] test-qobject-input-visitor: Abort earlier on bad test input Markus Armbruster
2017-02-28 16:52 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json() Markus Armbruster
2017-02-28 16:55 ` Kevin Wolf
2017-02-28 19:19 ` Eric Blake
2017-02-28 19:48 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 13/24] block: More detailed syntax error reporting for JSON filenames Markus Armbruster
2017-02-28 16:58 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 14/24] check-qjson: Test errors from qobject_from_json() Markus Armbruster
2017-02-28 17:06 ` Kevin Wolf
2017-02-28 19:25 ` Eric Blake
2017-02-28 19:52 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json() Markus Armbruster
2017-02-28 17:09 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 16/24] monitor: Assert qmp_schema_json[] is sane Markus Armbruster
2017-02-28 17:11 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 17/24] qapi: New qobject_input_visitor_new_str() for convenience Markus Armbruster
2017-02-28 17:18 ` Kevin Wolf
2017-02-28 18:48 ` Markus Armbruster
2017-02-28 19:29 ` Kevin Wolf
2017-02-28 17:33 ` Kevin Wolf
2017-02-28 18:45 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 18/24] block: Initial implementation of -blockdev Markus Armbruster
2017-02-28 19:38 ` Eric Blake
2017-02-28 19:57 ` Kevin Wolf
2017-02-28 20:59 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 19/24] qapi: Improve how keyval input visitor reports unexpected dicts Markus Armbruster
2017-02-28 17:51 ` Kevin Wolf
2017-02-28 18:52 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 20/24] docs/qapi-code-gen.txt: Clarify naming rules Markus Armbruster
2017-02-28 17:54 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 21/24] test-qapi-util: New, covering qapi/qapi-util.c Markus Armbruster
2017-02-28 17:57 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 22/24] qapi: New parse_qapi_name() Markus Armbruster
2017-02-28 18:02 ` Kevin Wolf
2017-02-28 18:54 ` Markus Armbruster
2017-02-28 19:48 ` Eric Blake
2017-02-27 11:20 ` [Qemu-devel] [PATCH 23/24] keyval: Restrict key components to valid QAPI names Markus Armbruster
2017-02-28 18:06 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 24/24] keyval: Support lists Markus Armbruster
2017-02-28 19:25 ` Kevin Wolf
2017-02-28 19:58 ` Markus Armbruster
2017-02-28 20:06 ` Eric Blake
2017-02-28 21:04 ` Markus Armbruster
2017-02-28 16:25 ` [Qemu-devel] [PATCH 00/24] block: Command line option -blockdev Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488194450-28056-1-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc="mdroth@linux.vnet.ibm.commdroth"@linux.vnet.ibm.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).