From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, pkrempa@redhat.com,
eblake@redhat.com,
"mdroth@linux.vnet.ibm.commdroth"@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 09/24] libqtest: Fix qmp() & friends to abort on JSON parse errors
Date: Mon, 27 Feb 2017 12:20:35 +0100 [thread overview]
Message-ID: <1488194450-28056-10-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1488194450-28056-1-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
tests/libqtest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 683d5e3..bb444d5 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -21,6 +21,7 @@
#include <sys/wait.h>
#include <sys/un.h>
+#include "qapi/error.h"
#include "qapi/qmp/json-parser.h"
#include "qapi/qmp/json-streamer.h"
#include "qapi/qmp/qjson.h"
@@ -442,7 +443,7 @@ void qmp_fd_sendv(int fd, const char *fmt, va_list ap)
* is an array type.
*/
va_copy(ap_copy, ap);
- qobj = qobject_from_jsonv(fmt, &ap_copy, NULL);
+ qobj = qobject_from_jsonv(fmt, &ap_copy, &error_abort);
va_end(ap_copy);
/* No need to send anything for an empty QObject. */
--
2.7.4
next prev parent reply other threads:[~2017-02-27 11:21 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 11:20 [Qemu-devel] [PATCH 00/24] block: Command line option -blockdev Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no" Markus Armbruster
2017-02-28 15:34 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 02/24] tests: Fix gcov-files-test-qemu-opts-y, gcov-files-test-logging-y Markus Armbruster
2017-02-28 15:34 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 03/24] keyval: New keyval_parse() Markus Armbruster
2017-02-28 15:48 ` Kevin Wolf
2017-02-28 16:36 ` Markus Armbruster
2017-02-28 16:57 ` Eric Blake
2017-02-28 18:03 ` Markus Armbruster
2017-02-28 18:51 ` Eric Blake
2017-02-28 19:15 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 04/24] qapi: qobject input visitor variant for use with keyval_parse() Markus Armbruster
2017-02-28 16:03 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 05/24] test-keyval: Cover use with qobject input visitor Markus Armbruster
2017-02-28 16:21 ` Kevin Wolf
2017-02-28 18:04 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 06/24] qapi: Factor out common part of qobject input visitor creation Markus Armbruster
2017-02-28 16:24 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 07/24] qapi: Factor out common qobject_input_get_keyval() Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 08/24] qobject: Propagate parse errors through qobject_from_jsonv() Markus Armbruster
2017-02-28 16:32 ` Kevin Wolf
2017-02-27 11:20 ` Markus Armbruster [this message]
2017-02-28 16:51 ` [Qemu-devel] [PATCH 09/24] libqtest: Fix qmp() & friends to abort on JSON parse errors Kevin Wolf
2017-02-28 18:05 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse Markus Armbruster
2017-02-28 16:51 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 11/24] test-qobject-input-visitor: Abort earlier on bad test input Markus Armbruster
2017-02-28 16:52 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 12/24] qobject: Propagate parse errors through qobject_from_json() Markus Armbruster
2017-02-28 16:55 ` Kevin Wolf
2017-02-28 19:19 ` Eric Blake
2017-02-28 19:48 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 13/24] block: More detailed syntax error reporting for JSON filenames Markus Armbruster
2017-02-28 16:58 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 14/24] check-qjson: Test errors from qobject_from_json() Markus Armbruster
2017-02-28 17:06 ` Kevin Wolf
2017-02-28 19:25 ` Eric Blake
2017-02-28 19:52 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 15/24] test-visitor-serialization: Pass &error_abort to qobject_from_json() Markus Armbruster
2017-02-28 17:09 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 16/24] monitor: Assert qmp_schema_json[] is sane Markus Armbruster
2017-02-28 17:11 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 17/24] qapi: New qobject_input_visitor_new_str() for convenience Markus Armbruster
2017-02-28 17:18 ` Kevin Wolf
2017-02-28 18:48 ` Markus Armbruster
2017-02-28 19:29 ` Kevin Wolf
2017-02-28 17:33 ` Kevin Wolf
2017-02-28 18:45 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 18/24] block: Initial implementation of -blockdev Markus Armbruster
2017-02-28 19:38 ` Eric Blake
2017-02-28 19:57 ` Kevin Wolf
2017-02-28 20:59 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 19/24] qapi: Improve how keyval input visitor reports unexpected dicts Markus Armbruster
2017-02-28 17:51 ` Kevin Wolf
2017-02-28 18:52 ` Markus Armbruster
2017-02-27 11:20 ` [Qemu-devel] [PATCH 20/24] docs/qapi-code-gen.txt: Clarify naming rules Markus Armbruster
2017-02-28 17:54 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 21/24] test-qapi-util: New, covering qapi/qapi-util.c Markus Armbruster
2017-02-28 17:57 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 22/24] qapi: New parse_qapi_name() Markus Armbruster
2017-02-28 18:02 ` Kevin Wolf
2017-02-28 18:54 ` Markus Armbruster
2017-02-28 19:48 ` Eric Blake
2017-02-27 11:20 ` [Qemu-devel] [PATCH 23/24] keyval: Restrict key components to valid QAPI names Markus Armbruster
2017-02-28 18:06 ` Kevin Wolf
2017-02-27 11:20 ` [Qemu-devel] [PATCH 24/24] keyval: Support lists Markus Armbruster
2017-02-28 19:25 ` Kevin Wolf
2017-02-28 19:58 ` Markus Armbruster
2017-02-28 20:06 ` Eric Blake
2017-02-28 21:04 ` Markus Armbruster
2017-02-28 16:25 ` [Qemu-devel] [PATCH 00/24] block: Command line option -blockdev Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488194450-28056-10-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc="mdroth@linux.vnet.ibm.commdroth"@linux.vnet.ibm.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).