qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [Qemu-devel] [PATCH v4 20/26] ppc/xics: register the reset handler of ICP objects
Date: Mon, 27 Feb 2017 15:29:27 +0100	[thread overview]
Message-ID: <1488205773-30436-21-git-send-email-clg@kaod.org> (raw)
In-Reply-To: <1488205773-30436-1-git-send-email-clg@kaod.org>

The reset of the ICP objects is currently handled by XICS but this can
be done for each individual ICP.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/intc/xics.c | 18 ------------------
 hw/ppc/spapr.c |  1 +
 2 files changed, 1 insertion(+), 18 deletions(-)

diff --git a/hw/intc/xics.c b/hw/intc/xics.c
index ddb0a6f48b5c..51e6c0c85fca 100644
--- a/hw/intc/xics.c
+++ b/hw/intc/xics.c
@@ -137,29 +137,11 @@ static void ics_simple_pic_print_info(InterruptStatsProvider *obj,
 /*
  * XICS Common class - parent for emulated XICS and KVM-XICS
  */
-static void xics_common_reset(DeviceState *d)
-{
-    XICSState *xics = XICS_COMMON(d);
-    int i;
-
-    for (i = 0; i < xics->nr_servers; i++) {
-        device_reset(DEVICE(&xics->ss[i]));
-    }
-}
-
-static void xics_common_class_init(ObjectClass *oc, void *data)
-{
-    DeviceClass *dc = DEVICE_CLASS(oc);
-
-    dc->reset = xics_common_reset;
-}
-
 static const TypeInfo xics_common_info = {
     .name          = TYPE_XICS_COMMON,
     .parent        = TYPE_DEVICE,
     .instance_size = sizeof(XICSState),
     .class_size    = sizeof(XICSStateClass),
-    .class_init    = xics_common_class_init,
 };
 
 /*
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index aa62292c8c90..88539557abd3 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -131,6 +131,7 @@ static XICSState *try_create_xics(sPAPRMachineState *spapr,
         ICPState *icp = &xics->ss[i];
 
         object_initialize(icp, sizeof(*icp), type_icp);
+        qdev_set_parent_bus(DEVICE(icp), sysbus_get_default());
         object_property_add_child(OBJECT(xics), "icp[*]", OBJECT(icp), NULL);
         object_property_add_const_link(OBJECT(icp), "xics", OBJECT(xi), NULL);
         object_property_set_bool(OBJECT(icp), true, "realized", &err);
-- 
2.7.4

  parent reply	other threads:[~2017-02-27 14:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 14:29 [Qemu-devel] [PATCH v4 00/26] ppc/xics: simplify ICS and ICP creation Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 01/26] xics: XICS should not be a SysBusDevice Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 02/26] ppc/xics: fix ICP and ICS reset Cédric Le Goater
2017-02-28  2:00   ` David Gibson
2017-02-28  6:54     ` Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 03/26] ppc/xics: remove set_nr_irqs() handler from XICSStateClass Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 04/26] ppc/xics: remove set_nr_servers() " Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 05/26] ppc/xics: store the ICS object under the sPAPR machine Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 06/26] ppc/xics: add an InterruptStatsProvider interface to ICS and ICP objects Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 07/26] ppc/xics: introduce a XICSFabric QOM interface to handle ICSs Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 08/26] ppc/xics: use the QOM interface under the sPAPR machine Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 09/26] ppc/xics: use the QOM interface to get irqs Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 10/26] ppc/xics: use the QOM interface to resend irqs Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 11/26] ppc/xics: remove xics_find_source() Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 12/26] ppc/xics: register the reset handler of ICS objects Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 13/26] ppc/xics: remove the XICS list of ICS Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 14/26] ppc/xics: extend the QOM interface to handle ICPs Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 15/26] ppc/xics: move kernel_xics_fd out of KVMXICSState Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 16/26] ppc/xics: simplify the cpu_setup() handler Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 17/26] ppc/xics: move the cpu_setup() handler under the ICPState class Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 18/26] ppc/xics: use the QOM interface to grab an ICP Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 19/26] ppc/xics: simplify spapr_dt_xics() interface Cédric Le Goater
2017-02-27 14:29 ` Cédric Le Goater [this message]
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 21/26] ppc/xics: move the ICP array under the sPAPR machine Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 22/26] ppc/xics: export the XICS init routines Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 23/26] ppc/xics: remove the XICSState classes Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 24/26] ppc/xics: move ics-simple post_load under the machine Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 25/26] ppc/xics: move InterruptStatsProvider to the sPAPR machine Cédric Le Goater
2017-02-27 14:29 ` [Qemu-devel] [PATCH v4 26/26] ppc/xics: rename 'ICPState *' variables to 'icp' Cédric Le Goater
2017-02-28  3:54 ` [Qemu-devel] [PATCH v4 00/26] ppc/xics: simplify ICS and ICP creation David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488205773-30436-21-git-send-email-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).