From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cidWj-0000w0-PF for qemu-devel@nongnu.org; Tue, 28 Feb 2017 03:52:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cidWg-0004ZO-Np for qemu-devel@nongnu.org; Tue, 28 Feb 2017 03:52:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40134) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cidWg-0004ZG-I3 for qemu-devel@nongnu.org; Tue, 28 Feb 2017 03:52:54 -0500 From: Thomas Huth Date: Tue, 28 Feb 2017 09:52:51 +0100 Message-Id: <1488271971-12624-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH] hw/core/null-machine: Print error message when using the -kernel parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Eduardo Habkost , Marcel Apfelbaum Cc: Peter Maydell If the user currently tries to use the -kernel parameter, simply nothing happens, and the user might get confused that there is nothing loaded to memory, but also no error message has been issued. Since there is no real generic way to load a kernel on all CPU types (but on some targets, the generic loader can be used instead), issue an appropriate error message here now to avoid the possible confusion. Signed-off-by: Thomas Huth --- hw/core/null-machine.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c index 27c8369..864832d 100644 --- a/hw/core/null-machine.c +++ b/hw/core/null-machine.c @@ -40,6 +40,12 @@ static void machine_none_init(MachineState *mch) memory_region_allocate_system_memory(ram, NULL, "ram", mch->ram_size); memory_region_add_subregion(get_system_memory(), 0, ram); } + + if (mch->kernel_filename) { + error_report("The -kernel parameter is not supported " + "(use the generic 'loader' device instead)."); + exit(1); + } } static void machine_none_machine_init(MachineClass *mc) -- 1.8.3.1