From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Richard Henderson <rth@twiddle.net>,
Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Laurent Vivier <laurent@vivier.eu>
Subject: [Qemu-devel] [PATCH for-2.9 2/6] disas/i386: Avoid NULL pointer dereference in error case
Date: Fri, 3 Mar 2017 15:50:29 +0000 [thread overview]
Message-ID: <1488556233-31246-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1488556233-31246-1-git-send-email-peter.maydell@linaro.org>
In a code path where we hit an internal disassembler error, execution
would subsequently attempt to dereference a NULL pointer. This
should never happen, but avoid the crash.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
disas/i386.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disas/i386.c b/disas/i386.c
index 07f871f..f1e376c 100644
--- a/disas/i386.c
+++ b/disas/i386.c
@@ -4043,7 +4043,7 @@ print_insn (bfd_vma pc, disassemble_info *info)
}
}
- if (putop (dp->name, sizeflag) == 0)
+ if (dp->name != NULL && putop (dp->name, sizeflag) == 0)
{
for (i = 0; i < MAX_OPERANDS; ++i)
{
--
2.7.4
next prev parent reply other threads:[~2017-03-03 16:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 15:50 [Qemu-devel] [PATCH for-2.9 0/6] disas: Fix various coverity nits Peter Maydell
2017-03-03 15:50 ` [Qemu-devel] [PATCH for-2.9 1/6] disas/hppa: Remove dead code Peter Maydell
2017-03-03 19:40 ` Philippe Mathieu-Daudé
2017-03-03 15:50 ` Peter Maydell [this message]
2017-03-03 15:50 ` [Qemu-devel] [PATCH for-2.9 3/6] disas/m68k: Avoid unintended sign extension in get_field() Peter Maydell
2017-03-03 18:56 ` Laurent Vivier
2017-03-03 15:50 ` [Qemu-devel] [PATCH for-2.9 4/6] disas/microblaze: Avoid unintended sign extension Peter Maydell
2017-03-03 15:58 ` Edgar E. Iglesias
2017-03-03 16:02 ` Peter Maydell
2017-03-03 16:06 ` Edgar E. Iglesias
2017-03-03 15:50 ` [Qemu-devel] [PATCH for-2.9 5/6] disas/cris: " Peter Maydell
2017-03-03 15:58 ` Edgar E. Iglesias
2017-03-03 19:43 ` Philippe Mathieu-Daudé
2017-03-03 15:50 ` [Qemu-devel] [PATCH for-2.9 6/6] disas/arm: " Peter Maydell
2017-03-03 16:11 ` [Qemu-devel] [PATCH for-2.9 0/6] disas: Fix various coverity nits no-reply
2017-03-04 0:00 ` no-reply
2017-03-04 12:44 ` Peter Maydell
2017-03-06 1:03 ` Fam Zheng
2017-03-07 17:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488556233-31246-3-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=laurent@vivier.eu \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).