From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com,
mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com,
jcody@redhat.com, ndevos@redhat.com, eblake@redhat.com,
f4bug@amsat.org
Subject: [Qemu-devel] [PATCH v2 15/15] sheepdog: Support blockdev-add
Date: Mon, 6 Mar 2017 20:00:49 +0100 [thread overview]
Message-ID: <1488826849-32384-16-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1488826849-32384-1-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
qapi/block-core.json | 27 ++++++++++++++++++++++++---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index d63be0a..9bb7f4a 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2124,6 +2124,7 @@
# @ssh: Since 2.8
# @iscsi: Since 2.9
# @rbd: Since 2.9
+# @sheepdog: Since 2.9
#
# Since: 2.0
##
@@ -2132,8 +2133,8 @@
'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
'host_device', 'http', 'https', 'iscsi', 'luks', 'nbd', 'nfs',
'null-aio', 'null-co', 'parallels', 'qcow', 'qcow2', 'qed',
- 'quorum', 'raw', 'rbd', 'replication', 'ssh', 'vdi', 'vhdx', 'vmdk',
- 'vpc', 'vvfat' ] }
+ 'quorum', 'raw', 'rbd', 'replication', 'sheepdog', 'ssh',
+ 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
##
# @BlockdevOptionsFile:
@@ -2692,6 +2693,26 @@
'*password-secret': 'str' } }
##
+# @BlockdevOptionsSheepdog:
+#
+# Driver specific block device options for sheepdog
+#
+# @vdi: Virtual disk image name
+# @addr: The Sheepdog server to connect to
+# @snap-id: Snapshot ID
+# @tag: Snapshot tag name
+#
+# Only one of @snap-id and @tag may be present.
+#
+# Since: 2.9
+##
+{ 'struct': 'BlockdevOptionsSheepdog',
+ 'data': { 'addr': 'SocketAddressFlat',
+ 'vdi': 'str',
+ '*snap-id': 'uint32',
+ '*tag': 'str' } }
+
+##
# @ReplicationMode:
#
# An enumeration of replication modes.
@@ -2891,7 +2912,7 @@
'raw': 'BlockdevOptionsRaw',
'rbd': 'BlockdevOptionsRbd',
'replication':'BlockdevOptionsReplication',
-# TODO sheepdog: Wait for structured options
+ 'sheepdog': 'BlockdevOptionsSheepdog',
'ssh': 'BlockdevOptionsSsh',
'vdi': 'BlockdevOptionsGenericFormat',
'vhdx': 'BlockdevOptionsGenericFormat',
--
2.7.4
next prev parent reply other threads:[~2017-03-06 19:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 19:00 [Qemu-devel] [PATCH v2 00/15] block: A bunch of fixes for Sheepdog and Gluster Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 01/15] sheepdog: Defuse time bomb in sd_open() error handling Markus Armbruster
2017-03-06 19:22 ` Eric Blake
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 02/15] sheepdog: Fix error handling in sd_snapshot_delete() Markus Armbruster
2017-03-06 19:25 ` Eric Blake
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 03/15] sheepdog: Fix error handling sd_create() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 04/15] sheepdog: Mark sd_snapshot_delete() lossage FIXME Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 05/15] sheepdog: Fix snapshot ID parsing in _open(), _create, _goto() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 06/15] sheepdog: Don't truncate long VDI name in _open(), _create() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 07/15] sheepdog: Report errors in pseudo-filename more usefully Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 08/15] sheepdog: Use SocketAddress and socket_connect() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 09/15] sheepdog: Implement bdrv_parse_filename() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 10/15] gluster: Drop assumptions on SocketTransport names Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 11/15] gluster: Don't duplicate qapi-util.c's qapi_enum_parse() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 12/15] gluster: Plug memory leaks in qemu_gluster_parse_json() Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 13/15] qapi-schema: Rename GlusterServer to SocketAddressFlat Markus Armbruster
2017-03-06 19:00 ` [Qemu-devel] [PATCH v2 14/15] qapi-schema: Rename SocketAddressFlat's variant tcp to inet Markus Armbruster
2017-03-06 19:00 ` Markus Armbruster [this message]
2017-03-07 13:09 ` [Qemu-devel] [PATCH v2 00/15] block: A bunch of fixes for Sheepdog and Gluster Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488826849-32384-16-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mitake.hitoshi@lab.ntt.co.jp \
--cc=namei.unix@gmail.com \
--cc=ndevos@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).