* [Qemu-devel] [PATCH] hw/ppc/pnv: Classify the "PowerNV Chip" devices as CPU devices
@ 2017-03-09 18:37 Thomas Huth
2017-03-10 1:00 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2017-03-09 18:37 UTC (permalink / raw)
To: qemu-ppc, qemu-devel, David Gibson; +Cc: Alexander Graf, Cédric Le Goater
The devices that are derived from TYPE_PNV_CHIP currently show up
as "uncategorized" devices in the help text of "-device ?". Since
they obviously are related to the CPU, let's put them into the
CPU category instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/ppc/pnv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 09f0d22..b97055c 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -722,6 +722,7 @@ static void pnv_chip_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
+ set_bit(DEVICE_CATEGORY_CPU, dc->categories);
dc->realize = pnv_chip_realize;
dc->props = pnv_chip_properties;
dc->desc = "PowerNV Chip";
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] hw/ppc/pnv: Classify the "PowerNV Chip" devices as CPU devices
2017-03-09 18:37 [Qemu-devel] [PATCH] hw/ppc/pnv: Classify the "PowerNV Chip" devices as CPU devices Thomas Huth
@ 2017-03-10 1:00 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2017-03-10 1:00 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-ppc, qemu-devel, Alexander Graf, Cédric Le Goater
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
On Thu, Mar 09, 2017 at 07:37:53PM +0100, Thomas Huth wrote:
> The devices that are derived from TYPE_PNV_CHIP currently show up
> as "uncategorized" devices in the help text of "-device ?". Since
> they obviously are related to the CPU, let's put them into the
> CPU category instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Applied to ppc-for-2.10.
> ---
> hw/ppc/pnv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 09f0d22..b97055c 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -722,6 +722,7 @@ static void pnv_chip_class_init(ObjectClass *klass, void *data)
> {
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> + set_bit(DEVICE_CATEGORY_CPU, dc->categories);
> dc->realize = pnv_chip_realize;
> dc->props = pnv_chip_properties;
> dc->desc = "PowerNV Chip";
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-10 1:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-09 18:37 [Qemu-devel] [PATCH] hw/ppc/pnv: Classify the "PowerNV Chip" devices as CPU devices Thomas Huth
2017-03-10 1:00 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).