* [Qemu-devel] [PATCH] virtio-pci: reset modern vq meta data
@ 2017-03-14 7:25 Jason Wang
2017-03-20 13:31 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2017-03-14 7:25 UTC (permalink / raw)
To: mst, qemu-devel; +Cc: Jason Wang, qemu-stable
We don't reset proxy->vqs[].{num|desc[]|avail[]|used[]}. This means if
a driver enable the vq without setting vq address after reset. The old
addresses were leaked. Fixing this by resetting modern vq meta data
during device reset.
Cc: qemu-stable@nongnu.org
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/virtio/virtio-pci.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index b76f3f6..7c36b9c 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -1857,6 +1857,10 @@ static void virtio_pci_reset(DeviceState *qdev)
for (i = 0; i < VIRTIO_QUEUE_MAX; i++) {
proxy->vqs[i].enabled = 0;
+ proxy->vqs[i].num = 0;
+ proxy->vqs[i].desc[0] = proxy->vqs[i].desc[1] = 0;
+ proxy->vqs[i].avail[0] = proxy->vqs[i].avail[1] = 0;
+ proxy->vqs[i].used[0] = proxy->vqs[i].used[1] = 0;
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-pci: reset modern vq meta data
2017-03-14 7:25 [Qemu-devel] [PATCH] virtio-pci: reset modern vq meta data Jason Wang
@ 2017-03-20 13:31 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2017-03-20 13:31 UTC (permalink / raw)
To: Jason Wang; +Cc: mst, qemu-devel, qemu-stable
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Tue, Mar 14, 2017 at 03:25:05PM +0800, Jason Wang wrote:
> We don't reset proxy->vqs[].{num|desc[]|avail[]|used[]}. This means if
> a driver enable the vq without setting vq address after reset. The old
> addresses were leaked. Fixing this by resetting modern vq meta data
> during device reset.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> hw/virtio/virtio-pci.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-20 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-14 7:25 [Qemu-devel] [PATCH] virtio-pci: reset modern vq meta data Jason Wang
2017-03-20 13:31 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).