From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 15/18] main-loop: remove now unnecessary optimization
Date: Tue, 14 Mar 2017 17:18:17 +0100 [thread overview]
Message-ID: <1489508300-48184-16-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1489508300-48184-1-git-send-email-pbonzini@redhat.com>
This optimization is not necessary anymore, because the vCPU now drops
the I/O thread lock even with TCG. Drop it to simplify the code and
avoid the "I/O thread spun for 1000 iterations" warning.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
vl.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 1a95500..0b4ed52 100644
--- a/vl.c
+++ b/vl.c
@@ -1888,17 +1888,14 @@ static bool main_loop_should_exit(void)
static void main_loop(void)
{
- bool nonblocking;
- int last_io = 0;
#ifdef CONFIG_PROFILER
int64_t ti;
#endif
do {
- nonblocking = tcg_enabled() && last_io > 0;
#ifdef CONFIG_PROFILER
ti = profile_getclock();
#endif
- last_io = main_loop_wait(nonblocking);
+ main_loop_wait(false);
#ifdef CONFIG_PROFILER
dev_time += profile_getclock() - ti;
#endif
--
1.8.3.1
next prev parent reply other threads:[~2017-03-14 16:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 16:18 [Qemu-devel] [PULL 00/18] Misc patches for QEMU 2.9 hard freeze Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 01/18] memory_region: Fix name comments Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 02/18] docs: Add a note about mixing bootindex with "-boot order" Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 03/18] mem-prealloc: reduce large guest start-up and migration time Paolo Bonzini
2017-03-18 13:58 ` Peter Maydell
2017-03-21 6:50 ` Jitendra Kolhe
2017-03-14 16:18 ` [Qemu-devel] [PULL 04/18] exec: add cpu_synchronize_state to cpu_memory_rw_debug Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 05/18] kvm: Print MSR information if KVM_{GET, SET}_MSRS failed Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 06/18] kvmclock: Don't crash QEMU if KVM is disabled Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 07/18] scripts/dump-guest-memory.py: fix int128_get64 on recent gcc Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 08/18] configure: add the missing help output for optional features Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 09/18] util: Removed unneeded header from path.c Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 10/18] scsi: mptsas: fix the wrong reading size in fetch request Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 11/18] target/nios2: take BQL around interrupt check Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 12/18] qemu-timer: fix off-by-one Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 13/18] qemu-timer: do not include sysemu/cpus.h from util/qemu-timer.h Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 14/18] cpus: define QEMUTimerListNotifyCB for QEMU system emulation Paolo Bonzini
2017-03-14 16:18 ` Paolo Bonzini [this message]
2017-03-14 16:18 ` [Qemu-devel] [PULL 16/18] icount: process QEMU_CLOCK_VIRTUAL timers in vCPU thread Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 17/18] memory: info mtree check mr range overflow Paolo Bonzini
2017-03-14 16:18 ` [Qemu-devel] [PULL 18/18] nbd/client: fix drop_sync [CVE-2017-2630] Paolo Bonzini
2017-03-14 17:09 ` Eric Blake
2017-03-14 19:16 ` [Qemu-devel] [PULL 00/18] Misc patches for QEMU 2.9 hard freeze Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489508300-48184-16-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).