From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7D41C56202 for ; Wed, 25 Nov 2020 15:04:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 012EF206B5 for ; Wed, 25 Nov 2020 15:04:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bRhbaiWC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 012EF206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khwLk-0003Lb-O1 for qemu-devel@archiver.kernel.org; Wed, 25 Nov 2020 10:04:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khwKb-0002pO-7e for qemu-devel@nongnu.org; Wed, 25 Nov 2020 10:03:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khwKV-0001ya-Tq for qemu-devel@nongnu.org; Wed, 25 Nov 2020 10:03:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606316612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ap8FJ3r0ZwfZhGE+Q6ek/PSrBU+dkZz8B7h2Aj3vZ6Q=; b=bRhbaiWCzq7l4gZcRoB7iiuhcjYF578NS1abqLzOGjDcVrViJyZUjBGwtOMPnU7RNKiXgG Q3Xc0t9RNNTswYU94hIkcHPHvkABNU+jTRua/u3WlZr5A10K6NVB1FQOEQaxWUxWh/3FfO w9avXMWtpk0drEN8tuozcAeF5DahnZM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-55-YQEdv8_UMMywsgSp3uOHEQ-1; Wed, 25 Nov 2020 10:03:26 -0500 X-MC-Unique: YQEdv8_UMMywsgSp3uOHEQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8967107ACE3; Wed, 25 Nov 2020 15:03:25 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-81.ams2.redhat.com [10.36.112.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16BE26087C; Wed, 25 Nov 2020 15:03:14 +0000 (UTC) Subject: Re: [PATCH RFC] tests/acceptance: add a test for devices on s390x To: Cornelia Huck , qemu-devel@nongnu.org References: <20201125135820.1442611-1-cohuck@redhat.com> From: Thomas Huth Message-ID: <148a7ef1-aae2-89ae-88f7-3c70c9f02999@redhat.com> Date: Wed, 25 Nov 2020 16:03:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201125135820.1442611-1-cohuck@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 25/11/2020 14.58, Cornelia Huck wrote: > This adds a very basic test for checking that we present devices > in a way that Linux can consume: boot with both virtio-net-ccw and > virtio-net-pci attached and then verify that Linux is able to see > and detect these devices. Thanks for tackling it! > Signed-off-by: Cornelia Huck > --- > > A very basic test, but it would have caught the recent zPCI regression. > > If anyone has a better idea than using early debug shells in the Debian > install image, please let me know. At least it's quick, as we can check > for the devices quite early in the boot sequence. > > Not sure if running under both kvm and tcg on an s390 host would add > useful extra coverage. Also not sure if this needs fencing on any of the > public CIs (have not tried yet). We're only running the acceptance tests in the gitlab-CI, no worries about the others. > --- > tests/acceptance/s390_devices.py | 68 ++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 tests/acceptance/s390_devices.py > > diff --git a/tests/acceptance/s390_devices.py b/tests/acceptance/s390_devices.py > new file mode 100644 > index 000000000000..6ce47061f35d > --- /dev/null > +++ b/tests/acceptance/s390_devices.py s390x_devices.py ? Or maybe even machine_s390x.py instead, like the other machine*.py files? > @@ -0,0 +1,68 @@ > +# Functional test that boots an s390x Linux guest with ccw and PCI devices > +# attached and checks whether the devices are recognized by Linux > +# > +# Copyright (c) 2020 Red Hat, Inc. > +# > +# Author: > +# Cornelia Huck > +# > +# This work is licensed under the terms of the GNU GPL, version 2 or > +# later. See the COPYING file in the top-level directory. > + > + > +import os > + > +from avocado_qemu import Test > +from avocado_qemu import exec_command_and_wait_for_pattern > +from avocado_qemu import wait_for_console_pattern > + > +class CheckS390xDevices(Test): > + KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 ' > + > + def wait_for_console_pattern(self, success_message, vm=None): > + wait_for_console_pattern(self, success_message, > + failure_message='Kernel panic - not syncing', > + vm=vm) > + > + timeout = 60 Running on public CIs can be slow ... I'd maybe directly start with 90 or 120 here. > + def test(self): > + > + """ > + :avocado: tags=arch:s390x > + :avocado: tags=machine:s390-ccw-virtio > + """ > + > + # XXX: switch to https when debian fixes their certificate > + kernel_url = ('http://archive.debian.org/debian/dists/jessie/main' > + '/installer-s390x/current/images/generic/kernel.debian') > + kernel_hash = '5af1aa839754f4d8817fb5878b4d55dfc887f45d' > + kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash) > + > + initrd_url = ('http://archive.debian.org/debian/dists/jessie/main' > + '/installer-s390x/current/images/generic/initrd.debian') > + initrd_hash = '99252b28306184b876f979585e2d4bfe96b27464' > + initrd_path = self.fetch_asset(initrd_url, asset_hash=initrd_hash) > + > + self.vm.set_console() > + kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + > + 'console=sclp0 root=/dev/ram0 BOOT_DEBUG=3') > + self.vm.add_args('-nographic', > + '-kernel', kernel_path, > + '-initrd', initrd_path, > + '-append', kernel_command_line, > + '-device', 'virtio-net-ccw,devno=fe.1.1111', > + '-device', 'virtio-net-pci') Maybe use '-device', 'virtio-net-pci,addr=6' or something similar to check a non-default PCI address, too? > + self.vm.launch() > + > + shell_ready = "sh: can't access tty; job control turned off" > + self.wait_for_console_pattern(shell_ready) > + # first debug shell is too early, we need to wait for device detection > + exec_command_and_wait_for_pattern(self, 'exit', shell_ready) > + > + ccw_bus_id="0.1.1111" > + pci_bus_id="0000:00:00.0" > + exec_command_and_wait_for_pattern(self, 'ls /sys/bus/ccw/devices/', > + ccw_bus_id) > + exec_command_and_wait_for_pattern(self, 'ls /sys/bus/pci/devices/', > + pci_bus_id) > Additional ideas (likely for later patches): Set a custom mac address for the virtio-net devices and check whether they show up correctly in the guest... Use "ping" to send some packets around (with -netdev user)... Thomas