From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpwvV-0003ui-O8 for qemu-devel@nongnu.org; Mon, 20 Mar 2017 09:00:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpwvT-00071G-A0 for qemu-devel@nongnu.org; Mon, 20 Mar 2017 09:00:45 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:36224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpwvT-00070o-04 for qemu-devel@nongnu.org; Mon, 20 Mar 2017 09:00:43 -0400 From: Yongbok Kim Date: Mon, 20 Mar 2017 13:00:20 +0000 Message-ID: <1490014826-4472-5-git-send-email-yongbok.kim@imgtec.com> In-Reply-To: <1490014826-4472-1-git-send-email-yongbok.kim@imgtec.com> References: <1490014826-4472-1-git-send-email-yongbok.kim@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL for v2.9 04/10] target-mips: replace break by goto cp0_unimplemented List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= From: Philippe Mathieu-Daud=C3=A9 this fixes many warnings like: target/mips/translate.c:6253:13: warning: Value stored to 'rn' is never r= ead rn =3D "invalid sel"; ^ ~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Yongbok Kim Signed-off-by: Yongbok Kim --- target/mips/translate.c | 88 ++++++++++++++++++++++++-------------------= ------ 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 5c030a9..fc11e15 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -5458,19 +5458,19 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg,= int reg, int sel) case 1: // gen_helper_mfc0_tracecontrol(arg); /* PDtrace support */ rn =3D "TraceControl"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mfc0_tracecontrol2(arg); /* PDtrace support */ rn =3D "TraceControl2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_mfc0_usertracedata(arg); /* PDtrace support */ rn =3D "UserTraceData"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mfc0_tracebpc(arg); /* PDtrace support */ rn =3D "TraceBPC"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -5496,31 +5496,31 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg,= int reg, int sel) case 1: // gen_helper_mfc0_performance1(arg); rn =3D "Performance1"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mfc0_performance2(arg); rn =3D "Performance2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_mfc0_performance3(arg); rn =3D "Performance3"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mfc0_performance4(arg); rn =3D "Performance4"; -// break; + goto cp0_unimplemented; case 5: // gen_helper_mfc0_performance5(arg); rn =3D "Performance5"; -// break; + goto cp0_unimplemented; case 6: // gen_helper_mfc0_performance6(arg); rn =3D "Performance6"; -// break; + goto cp0_unimplemented; case 7: // gen_helper_mfc0_performance7(arg); rn =3D "Performance7"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -6116,13 +6116,13 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg,= int reg, int sel) rn =3D "TraceControl"; /* Stop translation as we may have switched the execution mo= de */ ctx->bstate =3D BS_STOP; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mtc0_tracecontrol2(cpu_env, arg); /* PDtrace su= pport */ rn =3D "TraceControl2"; /* Stop translation as we may have switched the execution mo= de */ ctx->bstate =3D BS_STOP; -// break; + goto cp0_unimplemented; case 3: /* Stop translation as we may have switched the execution mo= de */ ctx->bstate =3D BS_STOP; @@ -6130,13 +6130,13 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg,= int reg, int sel) rn =3D "UserTraceData"; /* Stop translation as we may have switched the execution mo= de */ ctx->bstate =3D BS_STOP; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mtc0_tracebpc(cpu_env, arg); /* PDtrace support= */ /* Stop translation as we may have switched the execution mo= de */ ctx->bstate =3D BS_STOP; rn =3D "TraceBPC"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -6161,31 +6161,31 @@ static void gen_mtc0(DisasContext *ctx, TCGv arg,= int reg, int sel) case 1: // gen_helper_mtc0_performance1(arg); rn =3D "Performance1"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mtc0_performance2(arg); rn =3D "Performance2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_mtc0_performance3(arg); rn =3D "Performance3"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mtc0_performance4(arg); rn =3D "Performance4"; -// break; + goto cp0_unimplemented; case 5: // gen_helper_mtc0_performance5(arg); rn =3D "Performance5"; -// break; + goto cp0_unimplemented; case 6: // gen_helper_mtc0_performance6(arg); rn =3D "Performance6"; -// break; + goto cp0_unimplemented; case 7: // gen_helper_mtc0_performance7(arg); rn =3D "Performance7"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -6766,19 +6766,19 @@ static void gen_dmfc0(DisasContext *ctx, TCGv arg= , int reg, int sel) case 1: // gen_helper_dmfc0_tracecontrol(arg, cpu_env); /* PDtrace su= pport */ rn =3D "TraceControl"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_dmfc0_tracecontrol2(arg, cpu_env); /* PDtrace s= upport */ rn =3D "TraceControl2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_dmfc0_usertracedata(arg, cpu_env); /* PDtrace s= upport */ rn =3D "UserTraceData"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_dmfc0_tracebpc(arg, cpu_env); /* PDtrace suppor= t */ rn =3D "TraceBPC"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -6803,31 +6803,31 @@ static void gen_dmfc0(DisasContext *ctx, TCGv arg= , int reg, int sel) case 1: // gen_helper_dmfc0_performance1(arg); rn =3D "Performance1"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_dmfc0_performance2(arg); rn =3D "Performance2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_dmfc0_performance3(arg); rn =3D "Performance3"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_dmfc0_performance4(arg); rn =3D "Performance4"; -// break; + goto cp0_unimplemented; case 5: // gen_helper_dmfc0_performance5(arg); rn =3D "Performance5"; -// break; + goto cp0_unimplemented; case 6: // gen_helper_dmfc0_performance6(arg); rn =3D "Performance6"; -// break; + goto cp0_unimplemented; case 7: // gen_helper_dmfc0_performance7(arg); rn =3D "Performance7"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -7417,25 +7417,25 @@ static void gen_dmtc0(DisasContext *ctx, TCGv arg= , int reg, int sel) /* Stop translation as we may have switched the execution mo= de */ ctx->bstate =3D BS_STOP; rn =3D "TraceControl"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mtc0_tracecontrol2(cpu_env, arg); /* PDtrace su= pport */ /* Stop translation as we may have switched the execution mo= de */ ctx->bstate =3D BS_STOP; rn =3D "TraceControl2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_mtc0_usertracedata(cpu_env, arg); /* PDtrace su= pport */ /* Stop translation as we may have switched the execution mo= de */ ctx->bstate =3D BS_STOP; rn =3D "UserTraceData"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mtc0_tracebpc(cpu_env, arg); /* PDtrace support= */ /* Stop translation as we may have switched the execution mo= de */ ctx->bstate =3D BS_STOP; rn =3D "TraceBPC"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } @@ -7460,31 +7460,31 @@ static void gen_dmtc0(DisasContext *ctx, TCGv arg= , int reg, int sel) case 1: // gen_helper_mtc0_performance1(cpu_env, arg); rn =3D "Performance1"; -// break; + goto cp0_unimplemented; case 2: // gen_helper_mtc0_performance2(cpu_env, arg); rn =3D "Performance2"; -// break; + goto cp0_unimplemented; case 3: // gen_helper_mtc0_performance3(cpu_env, arg); rn =3D "Performance3"; -// break; + goto cp0_unimplemented; case 4: // gen_helper_mtc0_performance4(cpu_env, arg); rn =3D "Performance4"; -// break; + goto cp0_unimplemented; case 5: // gen_helper_mtc0_performance5(cpu_env, arg); rn =3D "Performance5"; -// break; + goto cp0_unimplemented; case 6: // gen_helper_mtc0_performance6(cpu_env, arg); rn =3D "Performance6"; -// break; + goto cp0_unimplemented; case 7: // gen_helper_mtc0_performance7(cpu_env, arg); rn =3D "Performance7"; -// break; + goto cp0_unimplemented; default: goto cp0_unimplemented; } --=20 2.7.4