qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yongbok Kim <yongbok.kim@imgtec.com>
To: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PULL for v2.9 06/10] target/mips: fix delay slot detection in gen_msa_branch()
Date: Mon, 20 Mar 2017 13:00:22 +0000	[thread overview]
Message-ID: <1490014826-4472-7-git-send-email-yongbok.kim@imgtec.com> (raw)
In-Reply-To: <1490014826-4472-1-git-send-email-yongbok.kim@imgtec.com>

It is unnecessary to test R6 from delay/forbidden slot check
in gen_msa_branch().

https://bugs.launchpad.net/qemu/+bug/1663287

Reported-by: Brian Campbell <bacam@z273.org.uk>
Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
---
 target/mips/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/mips/translate.c b/target/mips/translate.c
index 78b7264..3022f34 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -18162,7 +18162,7 @@ static void gen_msa_branch(CPUMIPSState *env, DisasContext *ctx, uint32_t op1)
 
     check_msa_access(ctx);
 
-    if (ctx->insn_flags & ISA_MIPS32R6 && ctx->hflags & MIPS_HFLAG_BMASK) {
+    if (ctx->hflags & MIPS_HFLAG_BMASK) {
         generate_exception_end(ctx, EXCP_RI);
         return;
     }
-- 
2.7.4

  parent reply	other threads:[~2017-03-20 13:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20 13:00 [Qemu-devel] [PULL for v2.9 00/10] target-mips queue Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 01/10] target-mips: fix compiler warnings (clang 5) Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 02/10] target-mips: remove old & unuseful comments Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 03/10] target-mips: log bad coprocessor0 register accesses with LOG_UNIMP Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 04/10] target-mips: replace break by goto cp0_unimplemented Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 05/10] target-mips: replace few LOG_DISAS() with trace points Yongbok Kim
2017-03-20 13:00 ` Yongbok Kim [this message]
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 07/10] dma: rc4030: limit interval timer reload value Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 08/10] dma/rc4030: translate memory accesses only when they occur Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 09/10] dma/rc4030: fix a mixed declarations and code warning Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 10/10] MAINTAINERS: update for MIPS devices Yongbok Kim
2017-03-20 15:43 ` [Qemu-devel] [PULL for v2.9 00/10] target-mips queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490014826-4472-7-git-send-email-yongbok.kim@imgtec.com \
    --to=yongbok.kim@imgtec.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).