From: Yongbok Kim <yongbok.kim@imgtec.com>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Prasad J Pandit <pjp@fedoraproject.org>
Subject: [Qemu-devel] [PULL for v2.9 07/10] dma: rc4030: limit interval timer reload value
Date: Mon, 20 Mar 2017 13:00:23 +0000 [thread overview]
Message-ID: <1490014826-4472-8-git-send-email-yongbok.kim@imgtec.com> (raw)
In-Reply-To: <1490014826-4472-1-git-send-email-yongbok.kim@imgtec.com>
From: Prasad J Pandit <pjp@fedoraproject.org>
The JAZZ RC4030 chipset emulator has a periodic timer and
associated interval reload register. The reload value is used
as divider when computing timer's next tick value. If reload
value is large, it could lead to divide by zero error. Limit
the interval reload value to avoid it.
Reported-by: Huawei PSIRT <psirt@huawei.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Tested-by: Hervé Poussineau <hpoussin@reactos.org>
Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
---
hw/dma/rc4030.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c
index 17c8518..41fc043 100644
--- a/hw/dma/rc4030.c
+++ b/hw/dma/rc4030.c
@@ -460,7 +460,7 @@ static void rc4030_write(void *opaque, hwaddr addr, uint64_t data,
break;
/* Interval timer reload */
case 0x0228:
- s->itr = val;
+ s->itr = val & 0x01FF;
qemu_irq_lower(s->timer_irq);
set_next_tick(s);
break;
--
2.7.4
next prev parent reply other threads:[~2017-03-20 13:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 13:00 [Qemu-devel] [PULL for v2.9 00/10] target-mips queue Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 01/10] target-mips: fix compiler warnings (clang 5) Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 02/10] target-mips: remove old & unuseful comments Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 03/10] target-mips: log bad coprocessor0 register accesses with LOG_UNIMP Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 04/10] target-mips: replace break by goto cp0_unimplemented Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 05/10] target-mips: replace few LOG_DISAS() with trace points Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 06/10] target/mips: fix delay slot detection in gen_msa_branch() Yongbok Kim
2017-03-20 13:00 ` Yongbok Kim [this message]
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 08/10] dma/rc4030: translate memory accesses only when they occur Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 09/10] dma/rc4030: fix a mixed declarations and code warning Yongbok Kim
2017-03-20 13:00 ` [Qemu-devel] [PULL for v2.9 10/10] MAINTAINERS: update for MIPS devices Yongbok Kim
2017-03-20 15:43 ` [Qemu-devel] [PULL for v2.9 00/10] target-mips queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490014826-4472-8-git-send-email-yongbok.kim@imgtec.com \
--to=yongbok.kim@imgtec.com \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).