qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: qemu-devel@nongnu.org
Cc: sstabellini@kernel.org, groug@kaod.org,
	Stefano Stabellini <stefano@aporeto.com>,
	anthony.perard@citrix.com, jgross@suse.com,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v4 2/8] 9p: introduce a type for the 9p header
Date: Mon, 20 Mar 2017 11:19:06 -0700	[thread overview]
Message-ID: <1490033952-26735-2-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1490033952-26735-1-git-send-email-sstabellini@kernel.org>

Use the new type in virtio-9p-device.

Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
CC: anthony.perard@citrix.com
CC: jgross@suse.com
CC: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
CC: Greg Kurz <groug@kaod.org>
---
 hw/9pfs/9p.h               | 6 ++++++
 hw/9pfs/virtio-9p-device.c | 6 +-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h
index b7e8362..5312d8a 100644
--- a/hw/9pfs/9p.h
+++ b/hw/9pfs/9p.h
@@ -119,6 +119,12 @@ static inline char *rpath(FsContext *ctx, const char *path)
 typedef struct V9fsPDU V9fsPDU;
 struct V9fsState;
 
+typedef struct {
+    uint32_t size_le;
+    uint8_t id;
+    uint16_t tag_le;
+} QEMU_PACKED P9MsgHeader;
+
 struct V9fsPDU
 {
     uint32_t size;
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index 27a4a32..3782f43 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -46,11 +46,7 @@ static void handle_9p_output(VirtIODevice *vdev, VirtQueue *vq)
     VirtQueueElement *elem;
 
     while ((pdu = pdu_alloc(s))) {
-        struct {
-            uint32_t size_le;
-            uint8_t id;
-            uint16_t tag_le;
-        } QEMU_PACKED out;
+        P9MsgHeader out;
 
         elem = virtqueue_pop(vq, sizeof(VirtQueueElement));
         if (!elem) {
-- 
1.9.1

  reply	other threads:[~2017-03-20 18:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20 18:18 [Qemu-devel] [PATCH v4 0/8] xen/9pfs: introduce the Xen 9pfs backend Stefano Stabellini
2017-03-20 18:19 ` [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen Stefano Stabellini
2017-03-20 18:19   ` Stefano Stabellini [this message]
2017-03-20 18:19   ` [Qemu-devel] [PATCH v4 3/8] xen/9pfs: introduce Xen 9pfs backend Stefano Stabellini
2017-03-20 18:19   ` [Qemu-devel] [PATCH v4 4/8] xen/9pfs: connect to the frontend Stefano Stabellini
2017-03-20 18:19   ` [Qemu-devel] [PATCH v4 5/8] xen/9pfs: receive requests from " Stefano Stabellini
2017-03-20 18:19   ` [Qemu-devel] [PATCH v4 6/8] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal Stefano Stabellini
2017-03-20 18:19   ` [Qemu-devel] [PATCH v4 7/8] xen/9pfs: send responses back to the frontend Stefano Stabellini
2017-03-20 18:19   ` [Qemu-devel] [PATCH v4 8/8] xen/9pfs: build and register Xen 9pfs backend Stefano Stabellini
2017-03-23 13:00   ` [Qemu-devel] [PATCH v4 1/8] xen: import ring.h from xen Greg Kurz
2017-03-23 13:55     ` Juergen Gross
2017-03-23 14:19       ` Paolo Bonzini
2017-03-23 15:05         ` Greg Kurz
2017-03-23 18:22         ` Stefano Stabellini
2017-03-24  6:02           ` Juergen Gross
2017-03-24 17:37             ` Stefano Stabellini
2017-03-27 12:41               ` Juergen Gross
2017-03-27 22:48                 ` Stefano Stabellini
2017-03-28  6:02                   ` Juergen Gross
2017-03-28 23:54                     ` Stefano Stabellini
2017-03-29  5:46                       ` Juergen Gross
2017-03-29  8:06                       ` Paolo Bonzini
2017-03-29 18:42                         ` Stefano Stabellini
2017-03-23 15:02       ` Greg Kurz
2017-03-21 10:20 ` [Qemu-devel] [PATCH v4 0/8] xen/9pfs: introduce the Xen 9pfs backend Greg Kurz
2017-03-21 20:14   ` Stefano Stabellini
2017-03-22  8:47     ` Greg Kurz
2017-03-22 18:32       ` [Qemu-devel] [Xen-devel] " Stefano Stabellini
2017-03-23  8:34         ` Greg Kurz
2017-03-23 16:49           ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490033952-26735-2-git-send-email-sstabellini@kernel.org \
    --to=sstabellini@kernel.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=anthony.perard@citrix.com \
    --cc=groug@kaod.org \
    --cc=jgross@suse.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano@aporeto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).