[Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

[Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

[wangguang]

Subject: [PATCH] Fix Colo doc secondeary should be secondary 
This is an error in COLO-FT.txt. 
secondeary-disk0 should be secondary-disk0. 

Signed-off-by: Guang Wang <wang.guang55@zte.com.cn>
--- 
 docs/COLO-FT.txt | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-) 

diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt 
index e289be2..bec7547 100644 
--- a/docs/COLO-FT.txt 
+++ b/docs/COLO-FT.txt 
@@ -139,7 +139,7 @@ Secondary: 
 { 'execute': 'nbd-server-start', 
   'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',
'port': '8889'} } } 
 } 
-{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0',
'writable': true } } 
+{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0',
'writable': true } } 
  
 Note: 
   a. The qmp command nbd-server-start and nbd-server-add must be run 
-- 
2.9.3 





--
View this message in context: http://qemu.11.n7.nabble.com/PATCH-v4-COLO-Fix-Colo-doc-secondeary-should-be-secondary-tp474433.html
Sent from the Developer mailing list archive at Nabble.com.

Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]

[adding qemu-trivial]

On 03/20/2017 07:27 PM, wangguang wrote:
> Subject: [PATCH] Fix Colo doc secondeary should be secondary 

This line feels redundant compared to the overall mail's subject line.
In turn, that subject could use a space after colon.

> This is an error in COLO-FT.txt. 
> secondeary-disk0 should be secondary-disk0. 
> 
> Signed-off-by: Guang Wang <wang.guang55@zte.com.cn>
> --- 
>  docs/COLO-FT.txt | 2 +- 
>  1 file changed, 1 insertion(+), 1 deletion(-) 

Reviewed-by: Eric Blake <eblake@redhat.com>

As it is doc-only, it is safe for hard freeze, but also not the end of
the world if it doesn't go in until 2.10.

> 
> diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt 
> index e289be2..bec7547 100644 
> --- a/docs/COLO-FT.txt 
> +++ b/docs/COLO-FT.txt 
> @@ -139,7 +139,7 @@ Secondary: 
>  { 'execute': 'nbd-server-start', 
>    'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',
> 'port': '8889'} } } 
>  } 
> -{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0',
> 'writable': true } } 
> +{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0',
> 'writable': true } } 
>   
>  Note: 
>    a. The qmp command nbd-server-start and nbd-server-add must be run 
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

[Dr. David Alan Gilbert]

* Eric Blake (eblake@redhat.com) wrote:
> [adding qemu-trivial]
> 
> On 03/20/2017 07:27 PM, wangguang wrote:
> > Subject: [PATCH] Fix Colo doc secondeary should be secondary 
> 
> This line feels redundant compared to the overall mail's subject line.
> In turn, that subject could use a space after colon.
> 
> > This is an error in COLO-FT.txt. 
> > secondeary-disk0 should be secondary-disk0. 
> > 
> > Signed-off-by: Guang Wang <wang.guang55@zte.com.cn>
> > --- 
> >  docs/COLO-FT.txt | 2 +- 
> >  1 file changed, 1 insertion(+), 1 deletion(-) 
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> As it is doc-only, it is safe for hard freeze, but also not the end of
> the world if it doesn't go in until 2.10.

Manually applied and queued for migration
(ahem a little late)

Dave

> > 
> > diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt 
> > index e289be2..bec7547 100644 
> > --- a/docs/COLO-FT.txt 
> > +++ b/docs/COLO-FT.txt 
> > @@ -139,7 +139,7 @@ Secondary: 
> >  { 'execute': 'nbd-server-start', 
> >    'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',
> > 'port': '8889'} } } 
> >  } 
> > -{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0',
> > 'writable': true } } 
> > +{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0',
> > 'writable': true } } 
> >   
> >  Note: 
> >    a. The qmp command nbd-server-start and nbd-server-add must be run 
> > 
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 


--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

[Qemu-devel] [PATCH v3]COLO:Fix Colo doc, secondeary should be secondary

[wangguang]

Subject: [PATCH] Fix Colo doc secondeary should be secondary 
This is an error in COLO-FT.txt. 
secondeary-disk0 should be secondary-disk0. 

Signed-off-by: Guang Wang <wang.guang55@zte.com.cn>
--- 
 docs/COLO-FT.txt | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-) 

diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt 
index e289be2..bec7547 100644 
--- a/docs/COLO-FT.txt 
+++ b/docs/COLO-FT.txt 
@@ -139,7 +139,7 @@ Secondary: 
 { 'execute': 'nbd-server-start', 
   'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',
'port': '8889'} } } 
 } 
-{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0',
'writable': true } } 
+{'execute': 'nbd-server-add', 'arguments': {'device': 'Secondary-disk0',
'writable': true } } 
  
 Note: 
   a. The qmp command nbd-server-start and nbd-server-add must be run 
-- 
2.9.3 

 





--
View this message in context: http://qemu.11.n7.nabble.com/PATCH-v3-COLO-Fix-Colo-doc-secondeary-should-be-secondary-tp474158.html
Sent from the Developer mailing list archive at Nabble.com.

Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

[wangguang]

Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error
in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by:
Guang Wang <wang.guang55@zte.com.cn>---  docs/COLO-FT.txt | 2 +-  1 file
changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/COLO-FT.txt
b/docs/COLO-FT.txt index e289be2..bec7547 100644 --- a/docs/COLO-FT.txt +++
b/docs/COLO-FT.txt @@ -139,7 +139,7 @@ Secondary:  { 'execute':
'nbd-server-start',    'arguments': {'addr': {'type': 'inet', 'data':
{'host': 'xx.xx.xx.xx', 'port': '8889'} } }  } -{'execute':
'nbd-server-add', 'arguments': {'device': 'secondeary-disk0', 'writable':
true } } +{'execute': 'nbd-server-add', 'arguments': {'device':
'secondary-disk0', 'writable': true } }    Note:    a. The qmp command
nbd-server-start and nbd-server-add must be run -- 2.9.3 



--
View this message in context: http://qemu.11.n7.nabble.com/PATCH-v3-COLO-Fix-Colo-doc-secondeary-should-be-secondary-tp474158p474432.html
Sent from the Developer mailing list archive at Nabble.com.

Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

On 03/20/2017 07:26 PM, wangguang wrote:
> Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error
> in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by:

> --
> View this message in context: http://qemu.11.n7.nabble.com/

Nabble may be a fine platform for viewing mailing list archives, and
even for commenting on existing posts without having a subscription, but
it is absolutely LOUSY at sending patches.  Please don't try to abuse
nabble for sending patches, but rather figure out how to get 'git
send-email' working properly.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH v4]COLO:Fix Colo doc, secondeary should be secondary

[Zhang Chen]

On 03/21/2017 11:05 AM, Eric Blake wrote:
> On 03/20/2017 07:26 PM, wangguang wrote:
>> Subject: [PATCH] Fix Colo doc secondeary should be secondary This is an error
>> in COLO-FT.txt. secondeary-disk0 should be secondary-disk0. Signed-off-by:
>> --
>> View this message in context: http://qemu.11.n7.nabble.com/
> Nabble may be a fine platform for viewing mailing list archives, and
> even for commenting on existing posts without having a subscription, but
> it is absolutely LOUSY at sending patches.  Please don't try to abuse
> nabble for sending patches, but rather figure out how to get 'git
> send-email' working properly.

I agree.

>

-- 
Thanks
Zhang Chen