From: Ladi Prosek <lprosek@redhat.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 0/2] virtio-input: eventq batching fixes
Date: Fri, 24 Mar 2017 15:24:48 +0100 [thread overview]
Message-ID: <1490365490-4854-1-git-send-email-lprosek@redhat.com> (raw)
Two bugs found when reviewing the code against the candidate spec:
* memory leak: the event queue is never freed
* incorrect virtqueue check: virtqueue_get_avail_bytes does not
guarantee number of available buffers
Ladi Prosek (2):
virtio-input: free event queue when finalizing
virtio-input: fix eventq batching
hw/input/virtio-input.c | 33 +++++++++++++++++----------------
include/hw/virtio/virtio-input.h | 5 ++++-
2 files changed, 21 insertions(+), 17 deletions(-)
Thanks!
Ladi
next reply other threads:[~2017-03-24 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 14:24 Ladi Prosek [this message]
2017-03-24 14:24 ` [Qemu-devel] [PATCH 1/2] virtio-input: free event queue when finalizing Ladi Prosek
2017-03-24 14:24 ` [Qemu-devel] [PATCH 2/2] virtio-input: fix eventq batching Ladi Prosek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490365490-4854-1-git-send-email-lprosek@redhat.com \
--to=lprosek@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).