From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>,
"\\ Dr . David Alan Gilbert \\ " <dgilbert@redhat.com>,
peterx@redhat.com
Subject: [Qemu-devel] [PATCH 3/5] hmp: info migrate_capability format tunes
Date: Mon, 27 Mar 2017 15:21:26 +0800 [thread overview]
Message-ID: <1490599288-11751-4-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1490599288-11751-1-git-send-email-peterx@redhat.com>
Dump the info in a single line is hard to read. Do it one per line.
Also, the first "capabilities:" didn't help much. Let's remove it.
CC: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
hmp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hmp.c b/hmp.c
index edb8970..95eef8c 100644
--- a/hmp.c
+++ b/hmp.c
@@ -265,13 +265,11 @@ void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict)
caps = qmp_query_migrate_capabilities(NULL);
if (caps) {
- monitor_printf(mon, "capabilities: ");
for (cap = caps; cap; cap = cap->next) {
- monitor_printf(mon, "%s: %s ",
+ monitor_printf(mon, "%s: %s\n",
MigrationCapability_lookup[cap->value->capability],
cap->value->state ? "on" : "off");
}
- monitor_printf(mon, "\n");
}
qapi_free_MigrationCapabilityStatusList(caps);
--
2.7.4
next prev parent reply other threads:[~2017-03-27 7:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 7:21 [Qemu-devel] [PATCH 0/5] several migrations related patches Peter Xu
2017-03-27 7:21 ` [Qemu-devel] [PATCH 1/5] migration: set current_active_state once Peter Xu
2017-03-31 18:50 ` Dr. David Alan Gilbert
2017-03-27 7:21 ` [Qemu-devel] [PATCH 2/5] migration: rename max_size to threshold_size Peter Xu
2017-03-31 18:59 ` Dr. David Alan Gilbert
2017-04-01 7:16 ` Peter Xu
2017-03-27 7:21 ` Peter Xu [this message]
2017-03-31 19:01 ` [Qemu-devel] [PATCH 3/5] hmp: info migrate_capability format tunes Dr. David Alan Gilbert
2017-03-27 7:21 ` [Qemu-devel] [PATCH 4/5] hmp: info migrate_parameters " Peter Xu
2017-03-31 19:02 ` Dr. David Alan Gilbert
2017-03-27 7:21 ` [Qemu-devel] [PATCH 5/5] cpu: throttle: fix throttle time slice Peter Xu
2017-03-27 7:40 ` Peter Xu
2017-03-31 16:38 ` Paolo Bonzini
2017-03-31 19:13 ` Dr. David Alan Gilbert
2017-03-31 19:46 ` Paolo Bonzini
2017-04-04 15:44 ` Dr. David Alan Gilbert
2017-04-01 7:52 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490599288-11751-4-git-send-email-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).