From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctc7C-0001Eb-UB for qemu-devel@nongnu.org; Thu, 30 Mar 2017 11:35:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctc78-0007wp-PE for qemu-devel@nongnu.org; Thu, 30 Mar 2017 11:35:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51224) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ctc78-0007vw-CW for qemu-devel@nongnu.org; Thu, 30 Mar 2017 11:35:54 -0400 Date: Thu, 30 Mar 2017 18:35:51 +0300 From: "Michael S. Tsirkin" Message-ID: <1490888143-31601-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] tests/acpi: don't pack a structure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Igor Mammedov There's no reason to pack structures where we don't care about size or padding, this applies to AcpiStdTable in tests/acpi-utils.h. OTOH bios-tables-test happens to be passing the address of a field in this struct to a function that expects a pointer to normally aligned data which results in a SIGBUS on architectures like SPARC that have strict alignment requirements. Fixes: 9e8458c02 ("acpi unit-test: compare DSDT and SSDT tables against expected values") Reported-by: Peter Maydell Signed-off-by: Michael S. Tsirkin --- tests/acpi-utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h index 9f9a2d5..348e4d7 100644 --- a/tests/acpi-utils.h +++ b/tests/acpi-utils.h @@ -26,7 +26,7 @@ typedef struct { gsize asl_len; gchar *asl_file; bool tmp_files_retain; /* do not delete the temp asl/aml */ -} QEMU_PACKED AcpiSdtTable; +} AcpiSdtTable; #define ACPI_READ_FIELD(field, addr) \ do { \ -- MST