From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: tianyu.lan@intel.com, Paolo Bonzini <pbonzini@redhat.com>,
kevin.tian@intel.com, yi.l.liu@intel.com,
Marcel Apfelbaum <marcel@redhat.com>,
"\\ Michael S . Tsirkin \\ " <mst@redhat.com>,
peterx@redhat.com, Jason Wang <jasowang@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH for-2.10 3/5] util: propagate error for device_func_init()
Date: Fri, 31 Mar 2017 15:36:31 +0800 [thread overview]
Message-ID: <1490945793-21276-4-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1490945793-21276-1-git-send-email-peterx@redhat.com>
We have error_propagate(). Use it.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index b97b32a..b18bde7 100644
--- a/vl.c
+++ b/vl.c
@@ -2304,7 +2304,7 @@ int device_init_func(void *opaque, QemuOpts *opts, Error **errp)
dev = qdev_device_add(opts, &err);
if (!dev) {
- error_report_err(err);
+ error_propagate(errp, err);
return -1;
}
object_unref(OBJECT(dev));
--
2.7.4
next prev parent reply other threads:[~2017-03-31 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 7:36 [Qemu-devel] [PATCH for-2.10 0/5] x86/vIOMMU: move init back to machine init phase Peter Xu
2017-03-31 7:36 ` [Qemu-devel] [PATCH for-2.10 1/5] QemuOpts: introduce qemu_opts_extract() Peter Xu
2017-03-31 7:36 ` [Qemu-devel] [PATCH for-2.10 2/5] util: export device_init_func() Peter Xu
2017-03-31 7:36 ` Peter Xu [this message]
2017-03-31 7:36 ` [Qemu-devel] [PATCH for-2.10 4/5] q35: init vIOMMU during machine init Peter Xu
2017-03-31 7:36 ` [Qemu-devel] [PATCH for-2.10 5/5] pci: move dma_as init back to bus realize Peter Xu
2017-03-31 16:17 ` [Qemu-devel] [PATCH for-2.10 0/5] x86/vIOMMU: move init back to machine init phase Michael S. Tsirkin
2017-04-01 1:29 ` Peter Xu
2017-04-11 9:22 ` Markus Armbruster
2017-04-11 10:08 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490945793-21276-4-git-send-email-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=kevin.tian@intel.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tianyu.lan@intel.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).