From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctr7b-0001N3-LW for qemu-devel@nongnu.org; Fri, 31 Mar 2017 03:37:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctr7a-0006zG-Rv for qemu-devel@nongnu.org; Fri, 31 Mar 2017 03:37:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49184) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ctr7a-0006z6-MV for qemu-devel@nongnu.org; Fri, 31 Mar 2017 03:37:22 -0400 From: Peter Xu Date: Fri, 31 Mar 2017 15:36:31 +0800 Message-Id: <1490945793-21276-4-git-send-email-peterx@redhat.com> In-Reply-To: <1490945793-21276-1-git-send-email-peterx@redhat.com> References: <1490945793-21276-1-git-send-email-peterx@redhat.com> Subject: [Qemu-devel] [PATCH for-2.10 3/5] util: propagate error for device_func_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: tianyu.lan@intel.com, Paolo Bonzini , kevin.tian@intel.com, yi.l.liu@intel.com, Marcel Apfelbaum , "\\ Michael S . Tsirkin \\ " , peterx@redhat.com, Jason Wang , Markus Armbruster We have error_propagate(). Use it. Signed-off-by: Peter Xu --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index b97b32a..b18bde7 100644 --- a/vl.c +++ b/vl.c @@ -2304,7 +2304,7 @@ int device_init_func(void *opaque, QemuOpts *opts, Error **errp) dev = qdev_device_add(opts, &err); if (!dev) { - error_report_err(err); + error_propagate(errp, err); return -1; } object_unref(OBJECT(dev)); -- 2.7.4