From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctxa8-0003ZX-TF for qemu-devel@nongnu.org; Fri, 31 Mar 2017 10:31:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctxa8-0001oI-51 for qemu-devel@nongnu.org; Fri, 31 Mar 2017 10:31:16 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:49019) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctxa7-0001nJ-Tt for qemu-devel@nongnu.org; Fri, 31 Mar 2017 10:31:16 -0400 From: Peter Maydell Date: Fri, 31 Mar 2017 15:31:11 +0100 Message-Id: <1490970671-20560-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] disas/cris.c: Avoid unintentional sign extension List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org, "Edgar E. Iglesias" Commit 001ebaca7b11 fixed some unintended sign extension issues spotted by Coverity (CID 1005402, 1005403), but didn't catch all of them. Fix the rest, so we behave consistently whether 'long' is 32 bit or 64 bit. Signed-off-by: Peter Maydell --- disas/cris.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/disas/cris.c b/disas/cris.c index 30217f1..2dd56de 100644 --- a/disas/cris.c +++ b/disas/cris.c @@ -2048,7 +2048,7 @@ print_with_operands (const struct cris_opcode *opcodep, { /* We're looking at [pc+], i.e. we need to output an immediate number, where the size can depend on different things. */ - long number; + int32_t number; int signedp = ((*cs == 'z' && (insn & 0x20)) || opcodep->match == BDAP_QUICK_OPCODE); @@ -2290,7 +2290,7 @@ print_with_operands (const struct cris_opcode *opcodep, if ((prefix_insn & 0x400) && (prefix_insn & 15) == 15) { - long number; + int32_t number; unsigned int nbytes; /* It's a value. Get its size. */ -- 2.7.4