From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cuEFb-00031g-3z for qemu-devel@nongnu.org; Sat, 01 Apr 2017 04:19:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cuEFX-0004Bz-Vm for qemu-devel@nongnu.org; Sat, 01 Apr 2017 04:19:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49028) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cuEFX-0004AL-Py for qemu-devel@nongnu.org; Sat, 01 Apr 2017 04:19:07 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CFF1F7E9D1 for ; Sat, 1 Apr 2017 08:19:06 +0000 (UTC) From: Peter Xu Date: Sat, 1 Apr 2017 16:18:44 +0800 Message-Id: <1491034725-23968-4-git-send-email-peterx@redhat.com> In-Reply-To: <1491034725-23968-1-git-send-email-peterx@redhat.com> References: <1491034725-23968-1-git-send-email-peterx@redhat.com> Subject: [Qemu-devel] [PATCH v2 3/4] hmp: info migrate_capability format tunes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Juan Quintela , "\\ Dr . David Alan Gilbert \\ " , peterx@redhat.com Dump the info in a single line is hard to read. Do it one per line. Also, the first "capabilities:" didn't help much. Let's remove it. CC: "Dr. David Alan Gilbert" Reviewed-by: "Dr. David Alan Gilbert" Signed-off-by: Peter Xu --- hmp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hmp.c b/hmp.c index edb8970..95eef8c 100644 --- a/hmp.c +++ b/hmp.c @@ -265,13 +265,11 @@ void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict) caps = qmp_query_migrate_capabilities(NULL); if (caps) { - monitor_printf(mon, "capabilities: "); for (cap = caps; cap; cap = cap->next) { - monitor_printf(mon, "%s: %s ", + monitor_printf(mon, "%s: %s\n", MigrationCapability_lookup[cap->value->capability], cap->value->state ? "on" : "off"); } - monitor_printf(mon, "\n"); } qapi_free_MigrationCapabilityStatusList(caps); -- 2.7.4