From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org, 1635339@bugs.launchpad.net
Subject: Re: [Qemu-devel] [PATCH v2] qxl: add migration blocker to avoid pre-save assert
Date: Mon, 10 Apr 2017 12:51:45 +0200 [thread overview]
Message-ID: <1491821505.30990.4.camel@redhat.com> (raw)
In-Reply-To: <CAJ+F1C+0rfVXxfXNRLkXx0qeE1u3jrH27kEQ7Ty3niTq1aSwaA@mail.gmail.com>
Hi,
> > + if (!qxl->migration_blocker) {
> > + Error *local_err = NULL;
> > + error_setg(&qxl->migration_blocker,
> > + "qxl: guest bug: command not in ram bar");
> > + migrate_add_blocker(qxl->migration_blocker,
> > &local_err);
> >
>
> What do you do with the local_err? error_report_err() perhaps ?
We can't error out at that point, unlike most migration blockers this
isn't added at device initialization time.
So, yes, we could error_report it, but the message would end up in the
logfile unnoticed, so I'm not sure how useful that is ...
cheers,
Gerd
next prev parent reply other threads:[~2017-04-10 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 10:27 [Qemu-devel] [PATCH v2] qxl: add migration blocker to avoid pre-save assert Gerd Hoffmann
2017-04-10 10:35 ` Marc-André Lureau
2017-04-10 10:51 ` Gerd Hoffmann [this message]
2017-04-10 10:59 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491821505.30990.4.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=1635339@bugs.launchpad.net \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).