From: Stefano Stabellini <sstabellini@kernel.org>
To: peter.maydell@linaro.org
Cc: stefanha@gmail.com, sstabellini@kernel.org, stefanha@redhat.com,
anthony.perard@citrix.com, xen-devel@lists.xenproject.org,
qemu-devel@nongnu.org, Stefano Stabellini <stefano@aporeto.com>,
jgross@suse.com,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Greg Kurz <groug@kaod.org>
Subject: [Qemu-devel] [PULL 11/21] 9p: introduce a type for the 9p header
Date: Fri, 21 Apr 2017 13:14:52 -0700 [thread overview]
Message-ID: <1492805702-19690-11-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1492805702-19690-1-git-send-email-sstabellini@kernel.org>
Use the new type in virtio-9p-device.
Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
CC: anthony.perard@citrix.com
CC: jgross@suse.com
CC: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
CC: Greg Kurz <groug@kaod.org>
---
hw/9pfs/9p.h | 6 ++++++
hw/9pfs/virtio-9p-device.c | 6 +-----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h
index b7e8362..5312d8a 100644
--- a/hw/9pfs/9p.h
+++ b/hw/9pfs/9p.h
@@ -119,6 +119,12 @@ static inline char *rpath(FsContext *ctx, const char *path)
typedef struct V9fsPDU V9fsPDU;
struct V9fsState;
+typedef struct {
+ uint32_t size_le;
+ uint8_t id;
+ uint16_t tag_le;
+} QEMU_PACKED P9MsgHeader;
+
struct V9fsPDU
{
uint32_t size;
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index 27a4a32..3782f43 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -46,11 +46,7 @@ static void handle_9p_output(VirtIODevice *vdev, VirtQueue *vq)
VirtQueueElement *elem;
while ((pdu = pdu_alloc(s))) {
- struct {
- uint32_t size_le;
- uint8_t id;
- uint16_t tag_le;
- } QEMU_PACKED out;
+ P9MsgHeader out;
elem = virtqueue_pop(vq, sizeof(VirtQueueElement));
if (!elem) {
--
1.9.1
next prev parent reply other threads:[~2017-04-21 20:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 20:14 [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10 Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 01/21] xen: make use of xen_xc implicit in xen_common.h inlines Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 02/21] xen: rename xen_modified_memory() to xen_hvm_modified_memory() Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 03/21] xen: create wrappers for all other uses of xc_hvm_XXX() functions Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 04/21] configure: detect presence of libxendevicemodel Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 05/21] xen: use libxendevicemodel when available Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 06/21] xen: use 5 digit xen versions Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 07/21] xen: use libxendevice model to restrict operations Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 08/21] xen: additionally restrict xenforeignmemory operations Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 09/21] configure: use pkg-config for obtaining xen version Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 10/21] xen: import ring.h from xen Stefano Stabellini
2017-04-21 20:14 ` Stefano Stabellini [this message]
2017-04-21 20:14 ` [Qemu-devel] [PULL 12/21] xen/9pfs: introduce Xen 9pfs backend Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 13/21] xen/9pfs: connect to the frontend Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 14/21] xen/9pfs: receive requests from " Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 15/21] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 16/21] xen/9pfs: send responses back to the frontend Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 17/21] xen/9pfs: build and register Xen 9pfs backend Stefano Stabellini
2017-04-21 20:14 ` [Qemu-devel] [PULL 18/21] add xen-9p-backend to MAINTAINERS under Xen Stefano Stabellini
2017-04-21 20:15 ` [Qemu-devel] [PULL 19/21] move xen-common.c to hw/xen/ Stefano Stabellini
2017-04-21 20:15 ` [Qemu-devel] [PULL 20/21] move xen-hvm.c to hw/i386/xen/ Stefano Stabellini
2017-04-21 20:15 ` [Qemu-devel] [PULL 21/21] move xen-mapcache.c " Stefano Stabellini
2017-04-24 10:31 ` [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10 Peter Maydell
2017-04-24 21:25 ` Stefano Stabellini
2017-04-24 21:46 ` Peter Maydell
2017-04-24 23:44 ` Stefano Stabellini
2017-04-25 6:44 ` Greg Kurz
2017-04-25 7:31 ` Markus Armbruster
2017-04-25 17:18 ` Stefano Stabellini
2017-04-26 6:44 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492805702-19690-11-git-send-email-sstabellini@kernel.org \
--to=sstabellini@kernel.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anthony.perard@citrix.com \
--cc=groug@kaod.org \
--cc=jgross@suse.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=stefano@aporeto.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).