* [Qemu-devel] [PATCH] net/dump: Issue a warning for the deprecated "-net dump"
@ 2017-04-25 7:50 Thomas Huth
2017-04-26 9:25 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2017-04-25 7:50 UTC (permalink / raw)
To: qemu-devel, Jason Wang
Network dumping should be done with "-object filter-dump" nowadays.
Using "-net dump" via the VLAN mechanism is considered as deprecated
and might be removed in a future release. So warn the users now
to inform them to user the filter-dump method instead.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
net/dump.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/dump.c b/net/dump.c
index 89a149b..442eb53 100644
--- a/net/dump.c
+++ b/net/dump.c
@@ -194,6 +194,9 @@ int net_init_dump(const Netdev *netdev, const char *name,
assert(peer);
+ error_report("'-net dump' is deprecated. "
+ "Please use '-object filter-dump' instead.");
+
if (dump->has_file) {
file = dump->file;
} else {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] net/dump: Issue a warning for the deprecated "-net dump"
2017-04-25 7:50 [Qemu-devel] [PATCH] net/dump: Issue a warning for the deprecated "-net dump" Thomas Huth
@ 2017-04-26 9:25 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2017-04-26 9:25 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
On 2017年04月25日 15:50, Thomas Huth wrote:
> Network dumping should be done with "-object filter-dump" nowadays.
> Using "-net dump" via the VLAN mechanism is considered as deprecated
> and might be removed in a future release. So warn the users now
> to inform them to user the filter-dump method instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> net/dump.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/dump.c b/net/dump.c
> index 89a149b..442eb53 100644
> --- a/net/dump.c
> +++ b/net/dump.c
> @@ -194,6 +194,9 @@ int net_init_dump(const Netdev *netdev, const char *name,
>
> assert(peer);
>
> + error_report("'-net dump' is deprecated. "
> + "Please use '-object filter-dump' instead.");
> +
> if (dump->has_file) {
> file = dump->file;
> } else {
Applied.
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-26 9:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-25 7:50 [Qemu-devel] [PATCH] net/dump: Issue a warning for the deprecated "-net dump" Thomas Huth
2017-04-26 9:25 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).