qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Sameeh Jubran <sameeh@daynix.com>,
	qemu-stable@nongnu.org
Subject: [Qemu-devel] [PULL 2/8] qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply
Date: Tue, 25 Apr 2017 18:04:35 -0500	[thread overview]
Message-ID: <1493161481-29595-3-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1493161481-29595-1-git-send-email-mdroth@linux.vnet.ibm.com>

From: Sameeh Jubran <sameeh@daynix.com>

The QGA schema states:

@can-offline: Whether offlining the VCPU is possible. This member
               is always filled in by the guest agent when the structure
               is returned, and always ignored on input (hence it can be
               omitted then).

Currently 'can-offline' is missing entirely from the reply. This causes
errors in libvirt which is expecting the reply to be compliant with the
schema docs.

BZ#1438735: https://bugzilla.redhat.com/show_bug.cgi?id=1438735

Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 qga/commands-win32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 04026ee..9fec1fb 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -1344,7 +1344,7 @@ GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp)
                     vcpu = g_malloc0(sizeof *vcpu);
                     vcpu->logical_id = current++;
                     vcpu->online = true;
-                    vcpu->has_can_offline = false;
+                    vcpu->has_can_offline = true;
 
                     entry = g_malloc0(sizeof *entry);
                     entry->value = vcpu;
-- 
2.7.4

  parent reply	other threads:[~2017-04-25 23:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 23:04 [Qemu-devel] [PULL 0/8] qemu-ga patch queue Michael Roth
2017-04-25 23:04 ` [Qemu-devel] [PULL 1/8] qemu-ga: Make QGA VSS provider service run only when needed Michael Roth
2017-04-25 23:04 ` Michael Roth [this message]
2017-04-25 23:04 ` [Qemu-devel] [PULL 3/8] qga-win: Fix a bug where qemu-ga service is stuck during stop operation Michael Roth
2017-04-25 23:04 ` [Qemu-devel] [PULL 4/8] qga-win: Fix Event Viewer errors caused by qemu-ga Michael Roth
2017-04-25 23:04 ` [Qemu-devel] [PULL 5/8] qga: Add 'guest-get-host-name' command Michael Roth
2017-04-25 23:04 ` [Qemu-devel] [PULL 6/8] qga: improve fsfreeze documentations Michael Roth
2017-04-25 23:04 ` [Qemu-devel] [PULL 7/8] qga: Add 'guest-get-users' command Michael Roth
2017-04-25 23:04 ` [Qemu-devel] [PULL 8/8] qga: Add `guest-get-timezone` command Michael Roth
2017-04-26 11:02   ` Daniel P. Berrange
2017-04-26 13:08     ` Eric Blake
2017-04-26 13:10       ` Daniel P. Berrange
2017-04-26 10:51 ` [Qemu-devel] [PULL 0/8] qemu-ga patch queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493161481-29595-3-git-send-email-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=sameeh@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).