From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, kraxel@redhat.com, pbonzini@redhat.com,
eblake@redhat.com, qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH 0/7] sockets: Flatten SocketAddress except in external interfaces
Date: Wed, 26 Apr 2017 09:36:35 +0200 [thread overview]
Message-ID: <1493192202-3184-1-git-send-email-armbru@redhat.com> (raw)
SocketAddress is a simple union, and simple unions are awkward: they
have their variant members wrapped in a "data" object on the wire, and
require additional indirections in C. Flatten it as follows: rename
SocketAddress to SocketAddressLegacy, rename its flat sibling
SocketAddressFlat to SocketAddress, convert all users of
SocketAddressLegacy to SocketAddress, except for existing external
interfaces. This completes the work outlined in commit 9445673.
Markus Armbruster (7):
sockets: Prepare vsock_parse() for flattened SocketAddress
sockets: Prepare inet_parse() for flattened SocketAddress
qapi: New QAPI_CLONE_MEMBERS()
sockets: Rename SocketAddress to SocketAddressLegacy
sockets: Rename SocketAddressFlat to SocketAddress
sockets: Limit SocketAddressLegacy except to external interfaces
socket: Delete unused helper socket_address_crumple()
block/gluster.c | 48 +++++------
block/nbd.c | 36 ++++-----
block/sheepdog.c | 20 ++---
blockdev-nbd.c | 21 +++--
chardev/char-socket.c | 42 +++++-----
chardev/char-udp.c | 20 +++--
hmp.c | 3 +-
include/block/nbd.h | 3 +
include/io/channel-socket.h | 4 +-
include/qapi/clone-visitor.h | 14 ++++
include/qemu/sockets.h | 18 ++---
io/dns-resolver.c | 17 ++--
migration/rdma.c | 4 +-
migration/socket.c | 20 +++--
qapi-schema.json | 36 +++++----
qapi/block-core.json | 6 +-
qapi/block.json | 2 +-
qapi/qapi-clone-visitor.c | 13 +++
qemu-nbd.c | 9 +--
qga/main.c | 4 +-
tests/test-io-channel-socket.c | 52 +++++-------
ui/vnc-auth-sasl.c | 5 +-
ui/vnc.c | 68 ++++++++--------
util/qemu-sockets.c | 177 +++++++++++++++++++----------------------
24 files changed, 328 insertions(+), 314 deletions(-)
--
2.7.4
next reply other threads:[~2017-04-26 7:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 7:36 Markus Armbruster [this message]
2017-04-26 7:36 ` [Qemu-devel] [PATCH 1/7] sockets: Prepare vsock_parse() for flattened SocketAddress Markus Armbruster
2017-04-26 15:14 ` Eric Blake
2017-04-26 7:36 ` [Qemu-devel] [PATCH 2/7] sockets: Prepare inet_parse() " Markus Armbruster
2017-04-26 15:28 ` Eric Blake
2017-04-26 7:36 ` [Qemu-devel] [PATCH 3/7] qapi: New QAPI_CLONE_MEMBERS() Markus Armbruster
2017-04-26 17:56 ` Eric Blake
2017-04-26 7:36 ` [Qemu-devel] [PATCH 4/7] sockets: Rename SocketAddress to SocketAddressLegacy Markus Armbruster
2017-04-26 19:08 ` Eric Blake
2017-04-26 7:36 ` [Qemu-devel] [PATCH 5/7] sockets: Rename SocketAddressFlat to SocketAddress Markus Armbruster
2017-04-26 19:15 ` Eric Blake
2017-04-27 5:53 ` Prasanna Kalever
2017-04-26 7:36 ` [Qemu-devel] [PATCH 6/7] sockets: Limit SocketAddressLegacy except to external interfaces Markus Armbruster
2017-04-26 19:45 ` Eric Blake
2017-04-27 7:26 ` Markus Armbruster
2017-04-27 7:33 ` Markus Armbruster
2017-04-26 7:36 ` [Qemu-devel] [PATCH 7/7] socket: Delete unused helper socket_address_crumple() Markus Armbruster
2017-04-26 19:45 ` Eric Blake
2017-04-28 8:15 ` [Qemu-devel] [PATCH 0/7] sockets: Flatten SocketAddress except in external interfaces Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493192202-3184-1-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).