From: "Liu, Yi L" <yi.l.liu@intel.com>
To: kvm@vger.kernel.org, iommu@lists.linux-foundation.org,
alex.williamson@redhat.com, peterx@redhat.com
Cc: jasowang@redhat.com, qemu-devel@nongnu.org, kevin.tian@intel.com,
ashok.raj@intel.com, jacob.jun.pan@intel.com,
tianyu.lan@intel.com, yi.l.liu@intel.com,
jean-philippe.brucker@arm.com,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
"Liu, Yi L" <yi.l.liu@linux.intel.com>
Subject: [Qemu-devel] [RFC PATCH 4/8] iommu/vt-d: Add iommu do invalidate function
Date: Wed, 26 Apr 2017 18:12:01 +0800 [thread overview]
Message-ID: <1493201525-14418-5-git-send-email-yi.l.liu@intel.com> (raw)
In-Reply-To: <1493201525-14418-1-git-send-email-yi.l.liu@intel.com>
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
This patch adds Intel VT-d specific function to implement
iommu_do_invalidate API.
The use case is for supporting caching structure invalidation
of assigned SVM capable devices. Emulated IOMMU exposes queue
invalidation capability and passes down all descriptors from the guest
to the physical IOMMU.
The assumption is that guest to host device ID mapping should be
resolved prior to calling IOMMU driver. Based on the device handle,
host IOMMU driver can replace certain fields before submit to the
invalidation queue.
Signed-off-by: Liu, Yi L <yi.l.liu@linux.intel.com>
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
drivers/iommu/intel-iommu.c | 43 +++++++++++++++++++++++++++++++++++++++++++
include/linux/intel-iommu.h | 11 +++++++++++
2 files changed, 54 insertions(+)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 6d5b939..0b098ad 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -5042,6 +5042,48 @@ static void intel_iommu_detach_device(struct iommu_domain *domain,
dmar_remove_one_dev_info(to_dmar_domain(domain), dev);
}
+static int intel_iommu_do_invalidate(struct iommu_domain *domain,
+ struct device *dev, struct tlb_invalidate_info *inv_info)
+{
+ int ret = 0;
+ struct intel_iommu *iommu;
+ struct dmar_domain *dmar_domain = to_dmar_domain(domain);
+ struct intel_invalidate_data *inv_data;
+ struct qi_desc *qi;
+ u16 did;
+ u8 bus, devfn;
+
+ if (!inv_info || !dmar_domain || (inv_info->model != INTEL_IOMMU))
+ return -EINVAL;
+
+ iommu = device_to_iommu(dev, &bus, &devfn);
+ if (!iommu)
+ return -ENODEV;
+
+ inv_data = (struct intel_invalidate_data *)&inv_info->opaque;
+
+ /* check SID */
+ if (PCI_DEVID(bus, devfn) != inv_data->sid)
+ return 0;
+
+ qi = &inv_data->inv_desc;
+
+ switch (qi->low & QI_TYPE_MASK) {
+ case QI_DIOTLB_TYPE:
+ case QI_DEIOTLB_TYPE:
+ /* for device IOTLB, we just let it pass through */
+ break;
+ default:
+ did = dmar_domain->iommu_did[iommu->seq_id];
+ set_mask_bits(&qi->low, QI_DID_MASK, QI_DID(did));
+ break;
+ }
+
+ ret = qi_submit_sync(qi, iommu);
+
+ return ret;
+}
+
static int intel_iommu_map(struct iommu_domain *domain,
unsigned long iova, phys_addr_t hpa,
size_t size, int iommu_prot)
@@ -5416,6 +5458,7 @@ static int intel_iommu_unbind_pasid_table(struct iommu_domain *domain,
#ifdef CONFIG_INTEL_IOMMU_SVM
.bind_pasid_table = intel_iommu_bind_pasid_table,
.unbind_pasid_table = intel_iommu_unbind_pasid_table,
+ .do_invalidate = intel_iommu_do_invalidate,
#endif
.map = intel_iommu_map,
.unmap = intel_iommu_unmap,
diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
index ac04f28..9d6562c 100644
--- a/include/linux/intel-iommu.h
+++ b/include/linux/intel-iommu.h
@@ -29,6 +29,7 @@
#include <linux/dma_remapping.h>
#include <linux/mmu_notifier.h>
#include <linux/list.h>
+#include <linux/bitops.h>
#include <asm/cacheflush.h>
#include <asm/iommu.h>
@@ -271,6 +272,10 @@ enum {
#define QI_PGRP_RESP_TYPE 0x9
#define QI_PSTRM_RESP_TYPE 0xa
+#define QI_DID(did) (((u64)did & 0xffff) << 16)
+#define QI_DID_MASK GENMASK(31, 16)
+#define QI_TYPE_MASK GENMASK(3, 0)
+
#define QI_IEC_SELECTIVE (((u64)1) << 4)
#define QI_IEC_IIDEX(idx) (((u64)(idx & 0xffff) << 32))
#define QI_IEC_IM(m) (((u64)(m & 0x1f) << 27))
@@ -529,6 +534,12 @@ struct intel_svm {
extern struct intel_iommu *intel_svm_device_to_iommu(struct device *dev);
#endif
+struct intel_invalidate_data {
+ u16 sid;
+ u32 pasid;
+ struct qi_desc inv_desc;
+};
+
extern const struct attribute_group *intel_iommu_groups[];
extern void intel_iommu_debugfs_init(void);
extern struct context_entry *iommu_context_addr(struct intel_iommu *iommu,
--
1.9.1
next prev parent reply other threads:[~2017-04-26 10:28 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 10:11 [Qemu-devel] [RFC PATCH 0/8] Shared Virtual Memory virtualization for VT-d Liu, Yi L
2017-04-26 10:11 ` [Qemu-devel] [RFC PATCH 1/8] iommu: Introduce bind_pasid_table API function Liu, Yi L
2017-04-26 16:56 ` Jean-Philippe Brucker
2017-04-26 18:29 ` jacob pan
2017-04-26 18:59 ` Jean-Philippe Brucker
2017-04-27 6:36 ` Liu, Yi L
2017-04-27 10:12 ` Jean-Philippe Brucker
2017-04-28 7:59 ` Liu, Yi L
2017-04-28 9:04 ` Liu, Yi L
2017-04-28 12:51 ` Jean-Philippe Brucker
2017-05-23 7:50 ` Liu, Yi L
2017-05-25 12:33 ` Jean-Philippe Brucker
2017-05-12 21:59 ` Alex Williamson
2017-05-14 10:56 ` Liu, Yi L
2017-04-26 10:11 ` [Qemu-devel] [RFC PATCH 2/8] iommu/vt-d: add bind_pasid_table function Liu, Yi L
2017-05-12 21:59 ` Alex Williamson
2017-05-15 13:14 ` jacob pan
2017-04-26 10:12 ` [Qemu-devel] [RFC PATCH 3/8] iommu: Introduce iommu do invalidate API function Liu, Yi L
2017-05-12 21:59 ` Alex Williamson
2017-05-17 10:23 ` Liu, Yi L
2017-04-26 10:12 ` Liu, Yi L [this message]
2017-05-12 21:59 ` [Qemu-devel] [RFC PATCH 4/8] iommu/vt-d: Add iommu do invalidate function Alex Williamson
2017-05-17 10:24 ` Liu, Yi L
2017-04-26 10:12 ` [Qemu-devel] [RFC PATCH 5/8] VFIO: Add new IOTCL for PASID Table bind propagation Liu, Yi L
2017-04-26 16:56 ` Jean-Philippe Brucker
2017-04-27 5:43 ` Liu, Yi L
2017-05-11 10:29 ` Liu, Yi L
2017-05-12 21:58 ` Alex Williamson
2017-05-17 10:27 ` Liu, Yi L
2017-05-18 11:29 ` Jean-Philippe Brucker
2017-04-26 10:12 ` [Qemu-devel] [RFC PATCH 6/8] VFIO: do pasid table binding Liu, Yi L
2017-05-09 7:55 ` Xiao Guangrong
2017-05-11 10:29 ` Liu, Yi L
2017-05-12 21:59 ` Alex Williamson
2017-04-26 10:12 ` [Qemu-devel] [RFC PATCH 7/8] VFIO: Add new IOCTL for IOMMU TLB invalidate propagation Liu, Yi L
2017-05-12 12:11 ` Jean-Philippe Brucker
2017-05-14 10:12 ` Liu, Yi L
2017-05-15 12:14 ` Jean-Philippe Brucker
2017-07-02 10:06 ` Liu, Yi L
2017-07-03 11:52 ` Jean-Philippe Brucker
2017-07-03 10:31 ` Liu, Yi L
2017-07-05 6:45 ` Tian, Kevin
2017-07-05 12:42 ` Jean-Philippe Brucker
2017-07-05 17:28 ` Alex Williamson
2017-07-05 22:26 ` Tian, Kevin
2017-07-14 8:58 ` Liu, Yi L
2017-07-14 18:15 ` Alex Williamson
2017-07-17 10:58 ` Liu, Yi L
2017-07-17 22:45 ` Alex Williamson
2017-07-18 9:38 ` Jean-Philippe Brucker
2017-07-18 14:29 ` Alex Williamson
2017-07-18 15:03 ` Jean-Philippe Brucker
2017-07-19 10:45 ` Liu, Yi L
2017-07-19 21:50 ` Jacob Pan
2017-07-05 22:31 ` Tian, Kevin
2017-05-12 21:58 ` Alex Williamson
2017-05-14 10:55 ` Liu, Yi L
2017-07-05 5:32 ` Tian, Kevin
2017-04-26 10:12 ` [Qemu-devel] [RFC PATCH 8/8] VFIO: do IOMMU TLB invalidation from guest Liu, Yi L
2017-05-08 4:09 ` [Qemu-devel] [RFC PATCH 0/8] Shared Virtual Memory virtualization for VT-d Xiao Guangrong
2017-05-07 7:33 ` Liu, Yi L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493201525-14418-5-git-send-email-yi.l.liu@intel.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=jean-philippe.brucker@arm.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tianyu.lan@intel.com \
--cc=yi.l.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).