From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Greg Kurz <groug@kaod.org>, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v2 2/4] 9pfs: drop pdu_push_and_notify()
Date: Thu, 27 Apr 2017 11:45:51 +0200 [thread overview]
Message-ID: <149328635105.30266.13681288439634920908.stgit@bahia> (raw)
In-Reply-To: <149328633283.30266.4224847428546759127.stgit@bahia>
Only pdu_complete() needs to notify the client that a request has completed.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
hw/9pfs/9p.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index c80ba67389ce..01deffa0c3b5 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -65,11 +65,6 @@ ssize_t pdu_unmarshal(V9fsPDU *pdu, size_t offset, const char *fmt, ...)
return ret;
}
-static void pdu_push_and_notify(V9fsPDU *pdu)
-{
- pdu->s->transport->push_and_notify(pdu);
-}
-
static int omode_to_uflags(int8_t mode)
{
int ret = 0;
@@ -668,7 +663,7 @@ static void coroutine_fn pdu_complete(V9fsPDU *pdu, ssize_t len)
pdu->size = len;
pdu->id = id;
- pdu_push_and_notify(pdu);
+ pdu->s->transport->push_and_notify(pdu);
/* Now wakeup anybody waiting in flush for this request */
if (!qemu_co_queue_next(&pdu->complete)) {
next prev parent reply other threads:[~2017-04-27 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 9:45 [Qemu-devel] [PATCH v2 0/4] 9pfs: handle transport errors Greg Kurz
2017-04-27 9:45 ` [Qemu-devel] [PATCH v2 1/4] fsdev: don't allow unknown format in marshal/unmarshal Greg Kurz
2017-04-27 18:15 ` Stefano Stabellini
2017-04-27 9:45 ` Greg Kurz [this message]
2017-04-27 18:17 ` [Qemu-devel] [PATCH v2 2/4] 9pfs: drop pdu_push_and_notify() Stefano Stabellini
2017-04-27 9:46 ` [Qemu-devel] [PATCH v2 3/4] virtio-9p: factor out virtio_9p_error_err() Greg Kurz
2017-04-27 9:46 ` [Qemu-devel] [PATCH v2 4/4] 9pfs: handle broken transport Greg Kurz
2017-04-27 18:51 ` Stefano Stabellini
2017-04-28 9:51 ` Greg Kurz
2017-04-27 11:02 ` [Qemu-devel] [PATCH v2 0/4] 9pfs: handle transport errors no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149328635105.30266.13681288439634920908.stgit@bahia \
--to=groug@kaod.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).