From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Huawei PSIRT <PSIRT@huawei.com>,
P J P <ppandit@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] input: limit kbd queue depth
Date: Fri, 28 Apr 2017 11:05:09 +0200 [thread overview]
Message-ID: <1493370309.23357.2.camel@redhat.com> (raw)
In-Reply-To: <20170428084906.GB23819@redhat.com>
On Fr, 2017-04-28 at 09:49 +0100, Daniel P. Berrange wrote:
> On Fri, Apr 28, 2017 at 10:42:37AM +0200, Gerd Hoffmann wrote:
> > Apply a limit to the number of items we accept into the keyboard queue.
>
> Is there a need for similar protection fir mouse input events from VNC ?
No, there is no delay queue for mouse events.
> > Impact: Without this limit vnc clients can exhaust host memory by
> > sending keyboard events faster than qemu feeds them to the guest.
>
> Ability for a remote network client to crash a host by exhausting
> memory should be considered a security flaw & have a CVE allocated
> for it.
Sure, it's WIP, Prasit will get one.
cheers,
Gerd
next prev parent reply other threads:[~2017-04-28 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 8:42 [Qemu-devel] [PATCH] input: limit kbd queue depth Gerd Hoffmann
2017-04-28 8:49 ` Daniel P. Berrange
2017-04-28 9:05 ` Gerd Hoffmann [this message]
2017-04-28 9:09 ` P J P
2017-04-28 12:27 ` Markus Armbruster
2017-05-02 7:12 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493370309.23357.2.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=PSIRT@huawei.com \
--cc=berrange@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).