qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH] Mark legacy option '-no-kvm' as deprecated
Date: Tue,  2 May 2017 13:54:22 +0200	[thread overview]
Message-ID: <1493726062-31743-1-git-send-email-thuth@redhat.com> (raw)

'-no-kvm' was just a legacy convenience option for the users of
qemu-kvm, it never made sense in the normal QEMU tree since TCG is
the default here anyway. The option has also never been specified
in the QEMU docs and in the '--help' list, so likely hardly anybody
knows about this option at all. I think we could get rid of this
without bothering anybody nowadays, but just in case, let's print
out a warning for a couple of releases first.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 vl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/vl.c b/vl.c
index d5ec87e..2d44621 100644
--- a/vl.c
+++ b/vl.c
@@ -3709,7 +3709,9 @@ int main(int argc, char **argv, char **envp)
                     exit(1);
                 }
                 break;
-             case QEMU_OPTION_no_kvm:
+            case QEMU_OPTION_no_kvm:
+                error_report("'-no-kvm' is depreacted, please use "
+                             "'-accel tcg' instead");
                 olist = qemu_find_opts("machine");
                 qemu_opts_parse_noisily(olist, "accel=tcg", false);
                 break;
-- 
1.8.3.1

             reply	other threads:[~2017-05-02 11:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02 11:54 Thomas Huth [this message]
2017-05-05 14:48 ` [Qemu-devel] [PATCH] Mark legacy option '-no-kvm' as deprecated Stefan Hajnoczi
2017-05-05 14:50   ` Daniel P. Berrange
2017-05-08  8:42     ` Markus Armbruster
2017-05-08  9:14       ` Thomas Huth
2017-05-08  9:40         ` Daniel P. Berrange
2017-05-08 10:15           ` Thomas Huth
2017-05-09  7:49             ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493726062-31743-1-git-send-email-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).