qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 02/28] test-keyval: fix leaks
Date: Thu,  4 May 2017 17:23:39 +0200	[thread overview]
Message-ID: <1493911445-19568-3-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1493911445-19568-1-git-send-email-armbru@redhat.com>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Spotted by ASAN.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20170503223846.6559-2-marcandre.lureau@redhat.com>
Reviewed-by: Eric blake <eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 tests/test-keyval.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/test-keyval.c b/tests/test-keyval.c
index ba19560..c556b1b 100644
--- a/tests/test-keyval.c
+++ b/tests/test-keyval.c
@@ -628,6 +628,7 @@ static void test_keyval_visit_alternate(void)
     visit_type_AltNumStr(v, "a", &ans, &error_abort);
     g_assert_cmpint(ans->type, ==, QTYPE_QSTRING);
     g_assert_cmpstr(ans->u.s, ==, "1");
+    qapi_free_AltNumStr(ans);
     visit_type_AltNumInt(v, "a", &ani, &err);
     error_free_or_abort(&err);
     visit_end_struct(v, NULL);
@@ -651,9 +652,12 @@ static void test_keyval_visit_any(void)
     g_assert(qlist);
     qstr = qobject_to_qstring(qlist_pop(qlist));
     g_assert_cmpstr(qstring_get_str(qstr), ==, "null");
+    QDECREF(qstr);
     qstr = qobject_to_qstring(qlist_pop(qlist));
     g_assert_cmpstr(qstring_get_str(qstr), ==, "1");
     g_assert(qlist_empty(qlist));
+    QDECREF(qstr);
+    qobject_decref(any);
     visit_check_struct(v, &error_abort);
     visit_end_struct(v, NULL);
     visit_free(v);
-- 
2.7.4

  parent reply	other threads:[~2017-05-04 15:24 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 15:23 [Qemu-devel] [PULL 00/28] QAPI patches for 2017-05-04 Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 01/28] tests/check-qdict: Fix missing brackets Markus Armbruster
2017-05-04 15:23 ` Markus Armbruster [this message]
2017-05-04 15:23 ` [Qemu-devel] [PULL 03/28] pci: Use struct instead of QDict to pass back parameters Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 04/28] pci: Reduce scope of error injection Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 05/28] coccinelle: Add script to remove useless QObject casts Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 06/28] qobject: Drop " Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 07/28] qobject: Add helper macros for common scalar insertions Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 08/28] qobject: Use simpler QDict/QList scalar insertion macros Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 09/28] block: Simplify bdrv_append_temp_snapshot() logic Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 10/28] QemuOpts: Simplify qemu_opts_to_qdict() Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 11/28] fdc-test: Avoid deprecated 'change' command Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 12/28] test-qga: Actually test 0xff sync bytes Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 13/28] sockets: Prepare vsock_parse() for flattened SocketAddress Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 14/28] sockets: Prepare inet_parse() " Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 15/28] qapi: New QAPI_CLONE_MEMBERS() Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 16/28] sockets: Rename SocketAddress to SocketAddressLegacy Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 17/28] sockets: Rename SocketAddressFlat to SocketAddress Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 18/28] sockets: Limit SocketAddressLegacy to external interfaces Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 19/28] sockets: Delete unused helper socket_address_crumple() Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 20/28] qmp: Improve QMP dispatch error messages Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 21/28] qobject-input-visitor: Document full_name_nth() Markus Armbruster
2017-05-04 15:23 ` [Qemu-devel] [PULL 22/28] qapi: Document intended use of @name within alternate visits Markus Armbruster
2017-05-04 15:24 ` [Qemu-devel] [PULL 23/28] qobject-input-visitor: Catch misuse of end_struct vs. end_list Markus Armbruster
2017-05-04 15:24 ` [Qemu-devel] [PULL 24/28] qmp-shell: add persistent command history Markus Armbruster
2017-05-04 15:24 ` [Qemu-devel] [PULL 25/28] qmp-shell: add -N option to skip negotiate Markus Armbruster
2017-05-04 15:24 ` [Qemu-devel] [PULL 26/28] qmp-shell: Cope with query-commands error Markus Armbruster
2017-05-04 15:24 ` [Qemu-devel] [PULL 27/28] qmp-shell: don't show version greeting if unavailable Markus Armbruster
2017-05-04 15:24 ` [Qemu-devel] [PULL 28/28] qmp-shell: improve help Markus Armbruster
2017-05-04 16:38 ` [Qemu-devel] [PULL 00/28] QAPI patches for 2017-05-04 no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493911445-19568-3-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).