From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, dgibson@redhat.com
Subject: [Qemu-devel] [PATCH] ppc: xics: fix compilation with CentOS 6
Date: Fri, 5 May 2017 11:48:50 +0200 [thread overview]
Message-ID: <1493977730-20581-1-git-send-email-pbonzini@redhat.com> (raw)
The PowerPCCPU typedef is included twice if a file includes
both hw/ppc/xics.h and target/ppc/cpu-qom.h.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
There are other failures but I don't have time to debug them today:
In file included from /tmp/qemu-test/src/include/hw/ppc/pnv.h:26,
from /tmp/qemu-test/src/hw/ppc/pnv.c:31:
/tmp/qemu-test/src/include/hw/ppc/pnv_psi.h:50: error: redefinition of typedef ‘PnvPsi’
/tmp/qemu-test/src/include/hw/ppc/pnv_lpc.h:26: note: previous declaration of ‘PnvPsi’ was here
In file included from /tmp/qemu-test/src/include/hw/ppc/pnv.h:27,
from /tmp/qemu-test/src/hw/ppc/pnv.c:31:
/tmp/qemu-test/src/include/hw/ppc/pnv_occ.h:25: error: redefinition of typedef ‘PnvPsi’
/tmp/qemu-test/src/include/hw/ppc/pnv_psi.h:50: note: previous declaration of ‘PnvPsi’ was here
In file included from /tmp/qemu-test/src/hw/ppc/pnv.c:39:
/tmp/qemu-test/src/include/hw/ipmi/ipmi.h:188: error: redefinition of typedef ‘IPMIBmc’
/tmp/qemu-test/src/include/hw/ppc/pnv.h:121: note: previous declaration of ‘IPMIBmc’ was here
make[1]: *** [hw/ppc/pnv.o] Error 1
Please start including Docker-based tests in your pre-pull-request tests.
include/hw/ppc/xics.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
index c215dc7..ce1942b 100644
--- a/include/hw/ppc/xics.h
+++ b/include/hw/ppc/xics.h
@@ -29,6 +29,7 @@
#define XICS_H
#include "hw/qdev.h"
+#include "target/ppc/cpu-qom.h"
#define XICS_IPI 0x2
#define XICS_BUID 0x1
@@ -46,7 +47,6 @@ typedef struct ICSStateClass ICSStateClass;
typedef struct ICSState ICSState;
typedef struct ICSIRQState ICSIRQState;
typedef struct XICSFabric XICSFabric;
-typedef struct PowerPCCPU PowerPCCPU;
#define TYPE_ICP "icp"
#define ICP(obj) OBJECT_CHECK(ICPState, (obj), TYPE_ICP)
--
1.8.3.1
next reply other threads:[~2017-05-05 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 9:48 Paolo Bonzini [this message]
2017-05-05 12:07 ` [Qemu-devel] [PATCH] ppc: xics: fix compilation with CentOS 6 Philippe Mathieu-Daudé
2017-05-08 6:13 ` David Gibson
2017-05-08 7:25 ` Paolo Bonzini
2017-05-10 5:55 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493977730-20581-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgibson@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).