qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pradeep Jagadeesh <pradeepkiruvale@gmail.com>
To: eric blake <eblake@redhat.com>, greg kurz <groug@kaod.org>
Cc: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,
	alberto garcia <berto@igalia.com>,
	jani kokkonen <jani.kokkonen@huawei.com>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v4 0/4] fsdev: qmp interface for io throttling
Date: Wed, 10 May 2017 04:41:19 -0400	[thread overview]
Message-ID: <1494405683-20877-1-git-send-email-pradeep.jagadeesh@huawei.com> (raw)

These patches provide the qmp interface, to query the io throttle 
status of the all fsdev devices that are present in a vm.
also, it provides an interface to set the io throttle parameters of a
fsdev to a required value. some of the patches also remove the duplicate
code that was present in block and fsdev files. 

Pradeep Jagadeesh (4):
  throttle: factor out duplicate code
  qmp: Create IOThrottle structure
  qmp: refactor duplicate code
  fsdev: QMP interface for throttling

 Makefile                        |   3 +
 blockdev.c                      |  97 ++-------------------------------
 fsdev/qemu-fsdev-dummy.c        |  10 ++++
 fsdev/qemu-fsdev-throttle.c     | 118 ++++++++++++++++++++++++++--------------
 fsdev/qemu-fsdev-throttle.h     |  13 +++++
 fsdev/qemu-fsdev.c              |  37 +++++++++++++
 hmp-commands-info.hx            |  19 +++++++
 hmp-commands.hx                 |  19 +++++++
 hmp.c                           |  88 ++++++++++++++++++++++++++++--
 hmp.h                           |   4 ++
 include/qemu/throttle-options.h |   7 +++
 qapi-schema.json                |   3 +
 qapi/block-core.json            |  76 +-------------------------
 qapi/fsdev.json                 |  84 ++++++++++++++++++++++++++++
 qapi/iothrottle.json            |  88 ++++++++++++++++++++++++++++++
 qmp.c                           |  15 +++++
 util/Makefile.objs              |   1 +
 util/throttle-options.c         | 105 +++++++++++++++++++++++++++++++++++
 18 files changed, 573 insertions(+), 214 deletions(-)
 create mode 100644 qapi/fsdev.json
 create mode 100644 qapi/iothrottle.json
 create mode 100644 util/throttle-options.c

v0 -> v1:
 Addressed comments from Eric Blake, Greg Kurz and Daniel P.Berrange
 Mainly renaming the functions and removing the redundant code.

v1 -> v2:
 Addressed comments from Eric Blake and Greg Kurz.
 As per the suggestion I split the patches into smaller patches.
 Removed some more duplicate code.

v2 -> v3:
 Addresssed comments from Alberto Garcia.
 Changed the comment from block to iothrottle in the iothrottle.json 
 Added the dummy functions in qemu-fsdev-dummy.c to address the compilation
 issues that were observed.

v3 -> v4:
 Addressed comments from Eric Blake and Greg Kurz
 Re-ordered the patches
 Added the dummy functions in qmp.c to address the cross compilation issues

-- 
1.8.3.1

             reply	other threads:[~2017-05-10  8:42 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10  8:41 Pradeep Jagadeesh [this message]
2017-05-10  8:41 ` [Qemu-devel] [PATCH v4 1/4] throttle: factor out duplicate code Pradeep Jagadeesh
2017-05-10 14:12   ` Greg Kurz
2017-05-10 15:27     ` Pradeep Jagadeesh
2017-05-10 19:48       ` Eric Blake
2017-05-11 16:12         ` Pradeep Jagadeesh
2017-05-10  8:41 ` [Qemu-devel] [PATCH v4 2/4] qmp: Create IOThrottle structure Pradeep Jagadeesh
2017-05-10  8:41 ` [Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code Pradeep Jagadeesh
2017-05-10 19:56   ` Eric Blake
2017-05-11 16:14     ` Pradeep Jagadeesh
2017-05-11  7:50   ` Greg Kurz
2017-05-12  8:03     ` Pradeep Jagadeesh
2017-06-08 14:20       ` Greg Kurz
2017-06-09  8:32         ` Pradeep Jagadeesh
2017-05-10  8:41 ` [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling Pradeep Jagadeesh
2017-05-10 20:00   ` Eric Blake
2017-05-17 14:53     ` Pradeep Jagadeesh
2017-05-17 15:28       ` Eric Blake
2017-05-17 16:29         ` Greg Kurz
2017-05-17 17:09           ` Eric Blake
2017-05-18 13:30             ` Pradeep Jagadeesh
2017-06-08 16:49               ` Greg Kurz
2017-06-09  8:31                 ` Pradeep Jagadeesh
2017-06-09  9:07                   ` Greg Kurz
2017-06-09  9:13                     ` Pradeep Jagadeesh
2017-06-09  9:20                       ` Greg Kurz
2017-05-10 10:02 ` [Qemu-devel] [PATCH v4 0/4] fsdev: qmp interface for io throttling no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494405683-20877-1-git-send-email-pradeep.jagadeesh@huawei.com \
    --to=pradeepkiruvale@gmail.com \
    --cc=berto@igalia.com \
    --cc=eblake@redhat.com \
    --cc=groug@kaod.org \
    --cc=jani.kokkonen@huawei.com \
    --cc=pradeep.jagadeesh@huawei.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).