From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Andrew Jones <drjones@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Eric Blake <eblake@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Shannon Zhao <zhaoshenglong@huawei.com>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org
Subject: [Qemu-devel] [PATCH v3 07/18] numa: do default mapping based on possible_cpus instead of node_cpu bitmaps
Date: Wed, 10 May 2017 13:29:51 +0200 [thread overview]
Message-ID: <1494415802-227633-8-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1494415802-227633-1-git-send-email-imammedo@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Andrew Jones <drjones@redhat.com>
---
numa.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/numa.c b/numa.c
index 7db5dde..c89fc2d 100644
--- a/numa.c
+++ b/numa.c
@@ -458,6 +458,7 @@ void numa_default_auto_assign_ram(MachineClass *mc, NodeInfo *nodes,
void parse_numa_opts(MachineState *ms)
{
int i;
+ const CPUArchIdList *possible_cpus;
MachineClass *mc = MACHINE_GET_CLASS(ms);
for (i = 0; i < MAX_NODES; i++) {
@@ -519,18 +520,21 @@ void parse_numa_opts(MachineState *ms)
numa_set_mem_ranges();
- for (i = 0; i < nb_numa_nodes; i++) {
- if (!bitmap_empty(numa_info[i].node_cpu, max_cpus)) {
- break;
- }
- }
-
/* assign CPUs to nodes using board provided default mapping */
- if (!mc->cpu_index_to_instance_props) {
+ if (!mc->cpu_index_to_instance_props || !mc->possible_cpu_arch_ids) {
error_report("default CPUs to NUMA node mapping isn't supported");
exit(1);
}
- if (i == nb_numa_nodes) {
+
+ possible_cpus = mc->possible_cpu_arch_ids(ms);
+ for (i = 0; i < possible_cpus->len; i++) {
+ if (possible_cpus->cpus[i].props.has_node_id) {
+ break;
+ }
+ }
+
+ /* no CPUs are assigned to NUMA nodes */
+ if (i == possible_cpus->len) {
for (i = 0; i < max_cpus; i++) {
CpuInstanceProperties props;
/* fetch default mapping from board and enable it */
--
2.7.4
next prev parent reply other threads:[~2017-05-10 11:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 11:29 [Qemu-devel] [PATCH v3 00/18] numa: add '-numa cpu' option Igor Mammedov
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 01/18] numa: move source of default CPUs to NUMA node mapping into boards Igor Mammedov
2017-05-11 4:36 ` David Gibson
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 02/18] spapr: add node-id property to sPAPR core Igor Mammedov
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 03/18] pc: add node-id property to CPU Igor Mammedov
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 04/18] virt-arm: " Igor Mammedov
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 05/18] numa: add check that board supports cpu_index to node mapping Igor Mammedov
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 06/18] numa: mirror cpu to node mapping in MachineState::possible_cpus Igor Mammedov
2017-05-26 15:46 ` Eduardo Habkost
2017-05-29 13:12 ` Igor Mammedov
2017-05-29 13:36 ` Eduardo Habkost
2017-05-29 13:49 ` Igor Mammedov
2017-05-30 12:13 ` Igor Mammedov
2017-05-30 14:04 ` Eduardo Habkost
2017-05-10 11:29 ` Igor Mammedov [this message]
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 08/18] pc: get numa node mapping from possible_cpus instead of numa_get_node_for_cpu() Igor Mammedov
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 09/18] spapr: " Igor Mammedov
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 10/18] virt-arm: " Igor Mammedov
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 11/18] QMP: include CpuInstanceProperties into query_cpus output output Igor Mammedov
2017-05-11 4:39 ` David Gibson
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 12/18] tests: numa: add case for QMP command query-cpus Igor Mammedov
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 13/18] numa: remove no longer need numa_post_machine_init() Igor Mammedov
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 14/18] machine: call machine init from wrapper Igor Mammedov
2017-05-10 11:29 ` [Qemu-devel] [PATCH v3 15/18] numa: use possible_cpus for not mapped CPUs check Igor Mammedov
2017-05-10 11:30 ` [Qemu-devel] [PATCH v3 16/18] numa: remove node_cpu bitmaps as they are no longer used Igor Mammedov
2017-05-10 11:30 ` [Qemu-devel] [PATCH v3 17/18] numa: add '-numa cpu, ...' option for property based node mapping Igor Mammedov
2017-05-11 5:23 ` David Gibson
2017-05-10 11:30 ` [Qemu-devel] [PATCH v3 18/18] tests: check -numa node, cpu=props_list usecase Igor Mammedov
2017-05-11 13:38 ` [Qemu-devel] [PATCH v3 00/18] numa: add '-numa cpu' option Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494415802-227633-8-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=drjones@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).