From: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
To: qemu devel <qemu-devel@nongnu.org>, Jason Wang <jasowang@redhat.com>
Cc: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
weifuqiang <weifuqiang@huawei.com>,
"eddie . dong" <eddie.dong@intel.com>,
bian naimeng <biannm@cn.fujitsu.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: [Qemu-devel] [PATCH V4 10/12] net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare
Date: Fri, 12 May 2017 09:41:26 +0800 [thread overview]
Message-ID: <1494553288-30764-11-git-send-email-zhangchen.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <1494553288-30764-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
COLO-Proxy just focus on packet payload, So we skip vnet header.
Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
---
net/colo-compare.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index cb0b04e..bf565f3 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -188,6 +188,8 @@ static int packet_enqueue(CompareState *s, int mode)
*/
static int colo_packet_compare_common(Packet *ppkt, Packet *spkt, int offset)
{
+ int offset_all;
+
if (trace_event_get_state(TRACE_COLO_COMPARE_MISCOMPARE)) {
char pri_ip_src[20], pri_ip_dst[20], sec_ip_src[20], sec_ip_dst[20];
@@ -201,9 +203,12 @@ static int colo_packet_compare_common(Packet *ppkt, Packet *spkt, int offset)
sec_ip_src, sec_ip_dst);
}
+ offset_all = ppkt->vnet_hdr_len + offset;
+
if (ppkt->size == spkt->size) {
- return memcmp(ppkt->data + offset, spkt->data + offset,
- spkt->size - offset);
+ return memcmp(ppkt->data + offset_all,
+ spkt->data + offset_all,
+ spkt->size - offset_all);
} else {
trace_colo_compare_main("Net packet size are not the same");
return -1;
@@ -261,8 +266,9 @@ static int colo_packet_compare_tcp(Packet *spkt, Packet *ppkt)
*/
if (ptcp->th_off > 5) {
ptrdiff_t tcp_offset;
+
tcp_offset = ppkt->transport_header - (uint8_t *)ppkt->data
- + (ptcp->th_off * 4);
+ + (ptcp->th_off * 4) - ppkt->vnet_hdr_len;
res = colo_packet_compare_common(ppkt, spkt, tcp_offset);
} else if (ptcp->th_sum == stcp->th_sum) {
res = colo_packet_compare_common(ppkt, spkt, ETH_HLEN);
--
2.7.4
next prev parent reply other threads:[~2017-05-12 1:44 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 1:41 [Qemu-devel] [PATCH V4 00/12] Add COLO-proxy virtio-net support Zhang Chen
2017-05-12 1:41 ` [Qemu-devel] [PATCH V4 01/12] net: Add vnet_hdr_len related arguments in NetClientState Zhang Chen
2017-05-13 21:24 ` Philippe Mathieu-Daudé
2017-05-15 3:24 ` Jason Wang
2017-05-15 6:56 ` Zhang Chen
2017-05-15 8:06 ` Jason Wang
2017-05-15 8:14 ` Zhang Chen
2017-05-16 6:49 ` Jason Wang
2017-05-23 12:06 ` Zhang Chen
2017-05-12 1:41 ` [Qemu-devel] [PATCH V4 02/12] net/filter-mirror.c: Add new option to enable vnet support for filter-mirror Zhang Chen
2017-05-13 1:49 ` Hailiang Zhang
2017-05-14 14:31 ` Zhang Chen
2017-05-15 3:26 ` Jason Wang
2017-05-15 6:57 ` Zhang Chen
2017-05-12 1:41 ` [Qemu-devel] [PATCH V4 03/12] net/filter-mirror.c: Make filter_mirror_send support vnet support Zhang Chen
2017-05-15 3:28 ` Jason Wang
2017-05-15 7:34 ` Zhang Chen
2017-05-12 1:41 ` [Qemu-devel] [PATCH V4 04/12] net/filter-mirror.c: Add new option to enable vnet support for filter-redirector Zhang Chen
2017-05-15 3:31 ` Jason Wang
2017-05-15 7:47 ` Zhang Chen
2017-05-12 1:41 ` [Qemu-devel] [PATCH V4 05/12] net/net.c: Add vnet_hdr support in SocketReadState Zhang Chen
2017-05-15 4:02 ` Jason Wang
2017-05-15 7:49 ` Zhang Chen
2017-05-12 1:41 ` [Qemu-devel] [PATCH V4 06/12] net/colo-compare.c: Add new option to enable vnet support for colo-compare Zhang Chen
2017-05-15 4:03 ` Jason Wang
2017-05-15 7:55 ` Zhang Chen
2017-05-12 1:41 ` [Qemu-devel] [PATCH V4 07/12] net/colo.c: Make vnet_hdr_len as packet property Zhang Chen
2017-05-15 4:05 ` Jason Wang
2017-05-15 8:03 ` Zhang Chen
2017-05-15 8:18 ` Jason Wang
2017-05-23 11:59 ` Zhang Chen
2017-05-12 1:41 ` [Qemu-devel] [PATCH V4 08/12] net/colo-compare.c: Make colo-compare support vnet_hdr_len Zhang Chen
2017-05-12 1:41 ` [Qemu-devel] [PATCH V4 09/12] net/colo.c: Add vnet packet parse feature in colo-proxy Zhang Chen
2017-05-12 1:41 ` Zhang Chen [this message]
2017-05-15 4:11 ` [Qemu-devel] [PATCH V4 10/12] net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare Jason Wang
2017-05-15 8:04 ` Zhang Chen
2017-05-12 1:41 ` [Qemu-devel] [PATCH V4 11/12] net/filter-rewriter.c: Add new option to enable vnet support for filter-rewriter Zhang Chen
2017-05-15 4:12 ` Jason Wang
2017-05-15 8:05 ` Zhang Chen
2017-05-12 1:41 ` [Qemu-devel] [PATCH V4 12/12] net/filter-rewriter.c: Make filter-rewriter support vnet_hdr_len Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494553288-30764-11-git-send-email-zhangchen.fnst@cn.fujitsu.com \
--to=zhangchen.fnst@cn.fujitsu.com \
--cc=biannm@cn.fujitsu.com \
--cc=eddie.dong@intel.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=weifuqiang@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).