From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/usb/dev-serial: Do not try to set vendorid or productid properties
Date: Fri, 12 May 2017 12:30:56 +0200 [thread overview]
Message-ID: <1494585056.14352.59.camel@redhat.com> (raw)
In-Reply-To: <1493883704-27604-1-git-send-email-thuth@redhat.com>
On Do, 2017-05-04 at 09:41 +0200, Thomas Huth wrote:
> When starting QEMU with the legacy USB serial device like this:
>
> qemu-system-x86_64 -usbdevice serial:vendorid=0x1234:stdio
>
> it currently aborts since the vendorid property does not exist
> anymore (it has been removed by commit f29783f72ea77dfbd7ea0c9):
>
> Unexpected error in object_property_find() at qemu/qom/object.c:1008:
> qemu-system-x86_64: -usbdevice serial:vendorid=0x1234:stdio: Property
> '.vendorid' not found
> Aborted (core dumped)
>
> Fix this crash by issuing a more friendly error message instead
> (and simplify the code also a little bit this way).
Added to usb queue.
thanks,
Gerd
prev parent reply other threads:[~2017-05-12 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 7:41 [Qemu-devel] [PATCH] hw/usb/dev-serial: Do not try to set vendorid or productid properties Thomas Huth
2017-05-12 10:30 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494585056.14352.59.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).