qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] sockets: ensure we can bind to both ipv4 & ipv6 separately
Date: Tue, 16 May 2017 15:55:35 +0200	[thread overview]
Message-ID: <1494942935.29008.52.camel@redhat.com> (raw)
In-Reply-To: <20170516133516.GC16341@redhat.com>

On Di, 2017-05-16 at 14:35 +0100, Daniel P. Berrange wrote:
> On Tue, May 16, 2017 at 03:29:51PM +0200, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > Separately from this patch, I noticed one further possible
> > > problem, 
> > > 
> > > Currently, the ipv4=on|off/ipv6=on|off settings are only
> > > used to determine what getaddrinfo results we request/use.
> > > 
> > > This leads to the somewhat odd situation where if you set
> > > ipv4=off,ipv6=on, QEMU won't be listening on an IPv4
> > > socket, but *will still* accept IPv4 clients over the IPv6
> > > socket due to our use of IPV6_V6ONLY=off.
> > 
> > Hmm, maybe we should just use IPV6_V6ONLY=on unconditionally?
> 
> This would certainly be my long term desire...
> 
> > Now that qemu finally supports multiple listening sockets we should be
> > able to do the switch without regressions, and it also should remove all
> > those nasty corner cases ...
> 
> ...but we can't do it yet - only the VNC server code has been reworked
> to support multiple listening sockets. We'd still have work todo on the
> NBD server, chardevs, migration, network socket backend and guest agent
> to support multiple listeners.

Ah, ok.

I guess then I would not worry too much that we break stuff in case
ipv4=off actually does what it is supposed to do ...

cheers,
  Gerd

      reply	other threads:[~2017-05-16 13:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-28 12:15 [Qemu-devel] [PATCH] sockets: ensure we can bind to both ipv4 & ipv6 separately Daniel P. Berrange
2017-04-28 14:57 ` Eric Blake
2017-04-28 14:59   ` Daniel P. Berrange
2017-04-28 15:31     ` Markus Armbruster
2017-05-16 12:39 ` Daniel P. Berrange
2017-05-16 13:29   ` Gerd Hoffmann
2017-05-16 13:35     ` Daniel P. Berrange
2017-05-16 13:55       ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494942935.29008.52.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).