From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au,
sam.bobroff@au1.ibm.com, rnsastry@linux.vnet.ibm.com,
Bharata B Rao <bharata@linux.vnet.ibm.com>
Subject: [Qemu-devel] [RFC PATCH v1 6/6] spapr: Fix migration of Radix guests
Date: Wed, 17 May 2017 09:19:22 +0530 [thread overview]
Message-ID: <1494992962-6929-7-git-send-email-bharata@linux.vnet.ibm.com> (raw)
In-Reply-To: <1494992962-6929-1-git-send-email-bharata@linux.vnet.ibm.com>
Fix migration of radix guests by ensuring that we issue
KVM_PPC_CONFIGURE_V3_MMU for radix case post migration.
Reported-by: Nageswara R Sastry <rnsastry@linux.vnet.ibm.com>
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
---
hw/ppc/spapr.c | 15 +++++++++++++++
hw/ppc/spapr_hcall.c | 1 +
include/hw/ppc/spapr.h | 1 +
3 files changed, 17 insertions(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 05abfc1..dd1d687 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1443,6 +1443,20 @@ static int spapr_post_load(void *opaque, int version_id)
err = spapr_rtc_import_offset(&spapr->rtc, spapr->rtc_offset);
}
+ if (spapr->patb_entry) {
+ if (kvmppc_has_cap_mmu_radix() && kvm_enabled()) {
+ err = kvmppc_configure_v3_mmu(POWERPC_CPU(first_cpu),
+ spapr->patb_flags &
+ SPAPR_PROC_TABLE_RADIX,
+ spapr->patb_flags &
+ SPAPR_PROC_TABLE_GTSE,
+ spapr->patb_entry);
+ } else {
+ error_report("Radix guest is unsupported by the host");
+ return -EINVAL;
+ }
+ }
+
return err;
}
@@ -1527,6 +1541,7 @@ static const VMStateDescription vmstate_spapr_patb_entry = {
.needed = spapr_patb_entry_needed,
.fields = (VMStateField[]) {
VMSTATE_UINT64(patb_entry, sPAPRMachineState),
+ VMSTATE_UINT64(patb_flags, sPAPRMachineState),
VMSTATE_END_OF_LIST()
},
};
diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
index 768aa57..b002fae 100644
--- a/hw/ppc/spapr_hcall.c
+++ b/hw/ppc/spapr_hcall.c
@@ -986,6 +986,7 @@ static target_ulong h_register_process_table(PowerPCCPU *cpu,
spapr_check_setup_free_hpt(spapr, spapr->patb_entry, cproc);
spapr->patb_entry = cproc; /* Save new process table */
+ spapr->patb_flags = flags; /* Save the flags */
/* Update the UPRT and GTSE bits in the LPCR for all cpus */
CPU_FOREACH(cs) {
diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index 5b39a26..c25a32e 100644
--- a/include/hw/ppc/spapr.h
+++ b/include/hw/ppc/spapr.h
@@ -75,6 +75,7 @@ struct sPAPRMachineState {
void *htab;
uint32_t htab_shift;
uint64_t patb_entry; /* Process tbl registed in H_REGISTER_PROCESS_TABLE */
+ uint64_t patb_flags;
hwaddr rma_size;
int vrma_adjust;
ssize_t rtas_size;
--
2.7.4
next prev parent reply other threads:[~2017-05-17 3:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 3:49 [Qemu-devel] [RFC PATCH v1 0/6] ppc/spapr: Fix migration of radix guests Bharata B Rao
2017-05-17 3:49 ` [Qemu-devel] [RFC PATCH v1 1/6] migration: Fix unregister_savevm() Bharata B Rao
2017-05-17 6:43 ` David Gibson
2017-05-17 10:12 ` Bharata B Rao
2017-05-17 3:49 ` [Qemu-devel] [RFC PATCH v1 2/6] migration: Introduce unregister_savevm_live() Bharata B Rao
2017-05-17 6:45 ` David Gibson
2017-05-17 7:21 ` Bharata B Rao
2017-05-17 3:49 ` [Qemu-devel] [RFC PATCH v1 3/6] spapr: Make h_register_process_table hcall flags global Bharata B Rao
2017-05-17 3:49 ` [Qemu-devel] [RFC PATCH v1 4/6] spapr: Consolidate HPT freeing code into a routine Bharata B Rao
2017-05-17 6:55 ` David Gibson
2017-05-17 3:49 ` [Qemu-devel] [RFC PATCH v1 5/6] spapr: Unregister HPT savevm handlers for radix guests Bharata B Rao
2017-05-17 6:59 ` David Gibson
2017-05-17 7:18 ` Bharata B Rao
2017-05-17 7:23 ` David Gibson
2017-05-17 3:49 ` Bharata B Rao [this message]
2017-05-17 7:00 ` [Qemu-devel] [RFC PATCH v1 6/6] spapr: Fix migration of Radix guests David Gibson
2017-05-17 7:15 ` Bharata B Rao
2017-05-17 7:20 ` David Gibson
2017-05-18 5:03 ` Bharata B Rao
2017-05-18 5:50 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494992962-6929-7-git-send-email-bharata@linux.vnet.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rnsastry@linux.vnet.ibm.com \
--cc=sam.bobroff@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).