qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"Herongguang (Stephen)" <herongguang.he@huawei.com>,
	qemu-stable@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>
Subject: [Qemu-devel] [PULL 12/13] pci: deassert intx when pci device unrealize
Date: Thu, 18 May 2017 00:45:32 +0300	[thread overview]
Message-ID: <1495057396-13387-13-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1495057396-13387-1-git-send-email-mst@redhat.com>

From: "Herongguang (Stephen)" <herongguang.he@huawei.com>

If a pci device is not reset by VM (by writing into config space)
and unplugged by VM, after that when VM reboots, qemu may assert:
pcibus_reset: Assertion `bus->irq_count[i] == 0' failed

Cc: qemu-stable@nongnu.org
Signed-off-by: herongguang <herongguang.he@huawei.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/pci/pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 259483b..98ccc27 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1083,6 +1083,7 @@ static void pci_qdev_unrealize(DeviceState *dev, Error **errp)
         pc->exit(pci_dev);
     }
 
+    pci_device_deassert_intx(pci_dev);
     do_pci_unregister_device(pci_dev);
 }
 
-- 
MST

  parent reply	other threads:[~2017-05-17 21:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 21:44 [Qemu-devel] [PULL 00/13] pci, virtio, vhost: fixes Michael S. Tsirkin
2017-05-17 21:45 ` [Qemu-devel] [PULL 01/13] hw/acpi-defs: replace leading X with x_ in FADT field names Michael S. Tsirkin
2017-05-17 21:45 ` [Qemu-devel] [PULL 02/13] hw/arm/virt: generate 64-bit addressable ACPI objects Michael S. Tsirkin
2017-05-17 21:45 ` [Qemu-devel] [PULL 03/13] hw/virtio: fix vhost user fails to startup when MQ Michael S. Tsirkin
2017-05-17 21:45 ` [Qemu-devel] [PULL 04/13] libvhost-user: fix crash when rings aren't ready Michael S. Tsirkin
2017-05-17 21:45 ` [Qemu-devel] [PULL 05/13] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot Michael S. Tsirkin
2017-05-17 21:45 ` [Qemu-devel] [PULL 06/13] pc: add 2.10 machine type Michael S. Tsirkin
2017-05-17 21:45 ` [Qemu-devel] [PULL 07/13] iommu: Don't crash if machine is not PC_MACHINE Michael S. Tsirkin
2017-05-17 21:45 ` [Qemu-devel] [PULL 08/13] ACPI: don't call acpi_pcihp_device_plug_cb on xen Michael S. Tsirkin
2017-05-17 21:45 ` [Qemu-devel] [PULL 09/13] acpi-defs: clean up open brace usage Michael S. Tsirkin
2017-05-17 21:45 ` [Qemu-devel] [PULL 10/13] Revert "hw/pci: disable pci-bridge's shpc by default" Michael S. Tsirkin
2017-05-17 21:45 ` [Qemu-devel] [PULL 11/13] virtio: allow broken device to notify guest Michael S. Tsirkin
2017-05-17 21:45 ` Michael S. Tsirkin [this message]
2017-05-17 21:45 ` [Qemu-devel] [PULL 13/13] exec: abstract address_space_do_translate() Michael S. Tsirkin
2017-05-17 22:29 ` [Qemu-devel] [PULL 00/13] pci, virtio, vhost: fixes no-reply
2017-05-17 22:34   ` Michael S. Tsirkin
2017-05-18  9:33 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495057396-13387-13-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=herongguang.he@huawei.com \
    --cc=marcel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).