From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com
Subject: [Qemu-devel] [PATCH RFC 3/6] migration: fix leak of src file on dst
Date: Fri, 19 May 2017 14:43:29 +0800 [thread overview]
Message-ID: <1495176212-14446-4-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1495176212-14446-1-git-send-email-peterx@redhat.com>
The return path channel is possibly leaked. Fix it.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/migration.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index e4f4c8c..92617fc 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -130,6 +130,11 @@ void migration_incoming_state_destroy(void)
{
struct MigrationIncomingState *mis = migration_incoming_get_current();
+ if (mis->to_src_file) {
+ qemu_fclose(mis->to_src_file);
+ mis->to_src_file = NULL;
+ }
+
qemu_event_destroy(&mis->main_thread_load_event);
loadvm_free_handlers(mis);
}
--
2.7.4
next prev parent reply other threads:[~2017-05-19 6:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 6:43 [Qemu-devel] [PATCH RFC 0/6] migration: enable return-path for precopy Peter Xu
2017-05-19 6:43 ` [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed Peter Xu
2017-05-19 8:25 ` Daniel P. Berrange
2017-05-19 8:30 ` Daniel P. Berrange
2017-05-19 9:55 ` Peter Xu
2017-05-19 12:54 ` Dr. David Alan Gilbert
2017-05-19 9:51 ` Peter Xu
2017-05-19 10:03 ` Daniel P. Berrange
2017-05-19 12:51 ` Dr. David Alan Gilbert
2017-05-19 12:56 ` Daniel P. Berrange
2017-05-19 13:02 ` Dr. David Alan Gilbert
2017-05-19 13:13 ` Daniel P. Berrange
2017-05-19 14:33 ` Dr. David Alan Gilbert
2017-05-19 14:51 ` Daniel P. Berrange
2017-05-19 18:41 ` Dr. David Alan Gilbert
2017-05-22 8:26 ` Daniel P. Berrange
2017-05-19 6:43 ` [Qemu-devel] [PATCH RFC 2/6] migration: isolate return path on src Peter Xu
2017-05-30 13:31 ` Juan Quintela
2017-05-19 6:43 ` Peter Xu [this message]
2017-05-30 15:49 ` [Qemu-devel] [PATCH RFC 3/6] migration: fix leak of src file on dst Juan Quintela
2017-05-31 9:51 ` Juan Quintela
2017-05-19 6:43 ` [Qemu-devel] [PATCH RFC 4/6] migration: shut src return path unconditionally Peter Xu
2017-05-19 19:28 ` Dr. David Alan Gilbert
2017-05-30 15:50 ` Juan Quintela
2017-05-31 7:31 ` Peter Xu
2017-05-31 7:36 ` Juan Quintela
2017-05-30 15:59 ` Juan Quintela
2017-06-05 20:22 ` Eric Blake
2017-06-06 2:00 ` Peter Xu
2017-05-19 6:43 ` [Qemu-devel] [PATCH RFC 5/6] migration: let MigrationState be an QObject Peter Xu
2017-05-30 15:57 ` Juan Quintela
2017-05-31 7:33 ` Peter Xu
2017-05-19 6:43 ` [Qemu-devel] [PATCH RFC 6/6] migration: enable return path for precopy Peter Xu
2017-05-30 15:59 ` Juan Quintela
2017-05-31 7:38 ` Peter Xu
2017-05-31 7:43 ` Juan Quintela
2017-05-31 8:04 ` Peter Xu
2017-05-31 8:12 ` Juan Quintela
2017-05-19 6:48 ` [Qemu-devel] [PATCH RFC 0/6] migration: enable return-path " Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495176212-14446-4-git-send-email-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).